Skip to content

CORE-1030: fix focus trap in treeChevron #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

jomcarvajal
Copy link
Contributor

@jomcarvajal jomcarvajal commented Jun 12, 2025

@jomcarvajal jomcarvajal requested a review from jivey June 12, 2025 20:49
@jivey
Copy link
Member

jivey commented Jun 12, 2025

@jomcarvajal Does 1.10.1 cover all the Tree bug fixes? It was published 2 days ago, so it might... I only put us on the nightly tag for a Tree fix.

@TomWoodward
Copy link
Member

i'm assuming the tabindex fix is still needed even with the version update? thats ok because you can still use the arrow keys to open/close the section? maybe @jivey should review again, i'm less familiar with this issue

@jomcarvajal
Copy link
Contributor Author

i'm assuming the tabindex fix is still needed even with the version update? thats ok because you can still use the arrow keys to open/close the section? maybe @jivey should review again, i'm less familiar with this issue

@TomWoodward the tabIndex is part of the update. As you can see the change is from our snap file. They put tabIndex -1 by default for Button inside the Tree. 👍

@jomcarvajal jomcarvajal merged commit 22eb984 into main Jun 16, 2025
3 checks passed
@jomcarvajal jomcarvajal deleted the CORE-1030/chevron-focus-trap branch June 16, 2025 15:14
@jivey
Copy link
Member

jivey commented Jun 17, 2025

Yeah the snap change looks right for this bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants