Skip to content

add pagination element #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openstax/ui-components",
"version": "1.16.0-pre2",
"version": "1.16.2",
"license": "MIT",
"source": "./src/index.ts",
"types": "./dist/index.d.ts",
Expand Down
62 changes: 62 additions & 0 deletions src/components/Pagination.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
import { render } from '@testing-library/react';
import { Pagination, LinkForPage } from "./Pagination";

describe('Pagination', () => {
let root: HTMLElement;

beforeEach(() => {
root = document.createElement('main');
root.id = 'root';
document.body.append(root);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno if it matters but this repo uses a lot of fragment snapshots

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk I just copied the other specs setup


it('matches snapshot', () => {
render(<Pagination
currentPage={1} totalPages={10}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} />
}
/>, {container: root});
expect(document.body).toMatchSnapshot();
});

it('matches snapshot with dividers', () => {
render(<Pagination
currentPage={5} totalPages={10} showFromEnd={1} showFromCurrent={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} />
}
/>, {container: root});
expect(document.body).toMatchSnapshot();
});

it('grows to min size', () => {
render(<Pagination
currentPage={1} totalPages={10} showFromEnd={1} showFromCurrent={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} />
}
/>, {container: root});
expect(document.body).toMatchSnapshot();
});

it('grows to min size from back', () => {
render(<Pagination
currentPage={10} totalPages={10} showFromEnd={1} showFromCurrent={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} />
}
/>, {container: root});
expect(document.body).toMatchSnapshot();
});

it('noops', () => {
render(<Pagination
currentPage={1} totalPages={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} />
}
/>, {container: root});
expect(document.body).toMatchSnapshot();
});
});
71 changes: 71 additions & 0 deletions src/components/Pagination.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import React from "react";
import { Pagination, LinkForPage } from "./Pagination";

export const Examples = () => {
const [currentPage, setCurrentPage] = React.useState(1);
return <div>
<h2>Default settings</h2>
<Pagination
currentPage={currentPage} totalPages={10}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>Showing only one link from the end</h2>
<Pagination
currentPage={currentPage} totalPages={10} showFromEnd={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>Showing zero links from the end</h2>
<Pagination
currentPage={currentPage} totalPages={10} showFromEnd={0}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>Showing only one link from the end and current</h2>
<Pagination
currentPage={currentPage} totalPages={10} showFromEnd={1} showFromCurrent={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>less links</h2>
<Pagination
currentPage={currentPage} totalPages={2}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>more links and summary</h2>
<Pagination
currentPage={currentPage} totalPages={40} totalItems={395} pageSize={10}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>zero links</h2>
<Pagination
currentPage={currentPage} totalPages={0}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>

<h2>one link</h2>
<Pagination
currentPage={currentPage} totalPages={1}
Page={({ page, current }) =>
<LinkForPage page={page} current={current} onClick={() => setCurrentPage(page)} />
}
/>
</div>
};
192 changes: 192 additions & 0 deletions src/components/Pagination.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
import React from 'react';
import styled from 'styled-components';
import { palette } from "../theme/palette";

export const LinkForPage = styled(({ page, current, href, onClick, className }: {
page: number;
current?: boolean;
href?: string;
className?: string;
onClick?: (event: React.MouseEvent<HTMLAnchorElement>) => void;
}) => {
const currentValue = current ? "page" : undefined;

return (
<a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an aria label for the link? When testing with a screenreader you only hear the numbers, which maybe works because of context, but I'm wondering if something like "Page x" or "Go to page x" would be clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I will add

className={className}
aria-current={currentValue}
href={href || '#'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we won't ever see this in practice, but with "#" the screenreader reads all of them as "visited link".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this would be invalid maybe I should just make href required

onClick={onClick}
>
{page}
</a>
);
})`
`;

export const Pagination = styled((props: {
className?: string;
Page: (props: {page: number; current: boolean}) => React.ReactElement;
currentPage: number;
totalPages: number;
totalItems?: number;
pageSize?: number;
showFromEnd?: number;
showFromCurrent?: number;
}) => {
const {
showFromEnd,
showFromCurrent,
pageSize,
totalItems,
className,
currentPage,
totalPages,
Page,
} = {
showFromEnd: 3,
showFromCurrent: 2,
...props
};

// the paginator would be empty, so short-circuit
if (totalPages === 0 || totalPages === 1) {
return null;
}

// prevent nav from changing size as you switch pages
const minEntries = showFromEnd * 2 + showFromCurrent * 2 +
1 + // the current page
2 // for the ellipsis
;

const middleRange: [number, number] = [
Math.max(1, Math.min(currentPage - showFromCurrent, totalPages + 1)),
Math.min(totalPages, currentPage + showFromCurrent) + 1
];
const startRange: [number, number] = [
1,
Math.min(middleRange[0], showFromEnd + 1)
];
const endRange: [number, number] = [
Math.max(1, middleRange[1], totalPages - showFromEnd + 1),
totalPages + 1
];

const numberOfEntries = Math.max(0, startRange[1] - startRange[0]) +
Math.max(0, middleRange[1] - middleRange[0]) +
Math.max(0, endRange[1] - endRange[0]) +
(startRange[1] === middleRange[0] ? 0 : 1) +
(middleRange[1] === endRange[0] ? 0 : 1)
;

if (numberOfEntries < minEntries) {
let remaining = minEntries - numberOfEntries;
const delta = Math.floor(remaining / 2);

const firstGap = middleRange[0] - startRange[1];
const secondGap = endRange[0] - middleRange[1];

const firstMod = Math.min(firstGap, secondGap === 0
// there is no second gap, try use entire diff in the first
? remaining
: secondGap < (remaining - delta)
// there is a gap but its smaller than the delta, so use it all
// in the first and add one for losing the ellipsis
? remaining - secondGap + 1
: delta
);
remaining -= firstMod;
const secondMod = Math.min(secondGap, remaining);

middleRange[0] = Math.max(1, middleRange[0] - firstMod);
middleRange[1] = Math.min(totalPages + 1, middleRange[1] + secondMod);
startRange[1] = Math.min(middleRange[0], showFromEnd + 1);
endRange[0] = Math.max(middleRange[1], totalPages - showFromEnd + 1);
}

return (
<div className={className}>
<nav aria-label="pagination links">
<ul>
{range(...startRange).map((p) =>
<li key={p} className={currentPage === p ? 'active' : undefined}>
<Page page={p} current={currentPage === p} />
</li>
)}
{startRange[1] !== middleRange[0] ?
<li className="disabled">
<span>...</span>
</li>
: null}
{range(...middleRange).map((p) =>
<li key={p} className={currentPage === p ? 'active' : undefined}>
<Page page={p} current={currentPage === p} />
</li>
)}
{middleRange[1] !== endRange[0] ?
<li className="disabled">
<span>...</span>
</li>
: null}
{range(...endRange).map((p) =>
<li key={p} className={currentPage === p ? 'active' : undefined}>
<Page page={p} current={currentPage === p} />
</li>
)}
</ul>
</nav>
{pageSize && totalItems ? <div className="pagination-info">
{(currentPage - 1) * pageSize + 1}-{Math.min(currentPage * pageSize, totalItems)} of {totalItems}
</div> : null}
</div>
);
})`
text-align: center;

> nav > ul {
list-style: none;
padding: 0;
border: thin solid ${palette.neutralLight};
border-radius: 0.5rem;
display: inline-block;
margin: 0 auto;

> li {
margin: 0;
min-width: 4rem;
text-align: center;
display: inline-block;

&:not(:last-child) {
border-right: thin solid ${palette.neutralLight};
}

&.active,
&:focus-within:not(.disabled),
&:hover:not(.disabled) {
background-color: ${palette.neutralLighter};
}

> ${LinkForPage},span {
padding: 1rem;
display: block;
text-decoration: none;
font-size: 1.6rem;
line-height: 1.3rem;
margin: 0;
color: inherit;
}
}
}

.pagination-info {
margin-top: 0.5rem;
font-size: 1.6rem;
}
`;

function range(lower: number, upper: number) {
if (upper < lower) return [];
return Array.from({length: upper-lower}).map((_, i) => i + lower);
}
Loading
Loading