CORE-675: rename SectionNav to ButtonNav and refactor props from ToggleButtonGroup #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivey
reviewed
Apr 28, 2025
src/components/ButtonNav.stories.tsx
Outdated
| newSet.add(firstSectionKeys[currentIndex - 1]); | ||
| scrollToIndex(firstSectionKeys[currentIndex - 1]); | ||
| newSelectedItem = flattenedSections[currentIndex - 1].id; | ||
| scrollNavToSection(flattenedSections[currentIndex - 1].id); |
| selectedItems: Set<Key>; | ||
| onSelectionChange?: React.Dispatch<React.SetStateAction<Set<Key>>>; | ||
| selectedItems: Iterable<Key> | undefined; | ||
| onSelectionChange?: ((keys: Set<Key>) => void) | undefined; |
There was a problem hiding this comment.
Doesn't this already get typed as undefined because of the ??
jivey
reviewed
Apr 28, 2025
src/components/ButtonNav.stories.tsx
Outdated
| selectedItems={selectedItems} | ||
| onSelectionChange={setSelectedItems} | ||
| selectedItems={new Set<Key>([selectedItem])} | ||
| onSelectionChange={(newSet) => setSelectedItem([...newSet][0] as string)} |
There was a problem hiding this comment.
This can be an empty set right? Unselecting an item will throw an error
jivey
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-675
Rename SectionNav to ButtonNav and refactor props from ToggleButtonGroup