More form fixes #83
Merged
More form fixes #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivey
approved these changes
Apr 24, 2025
src/components/Button.tsx
Outdated
| </button>; | ||
| })` | ||
| ${buttonCss} | ||
| ` |
There was a problem hiding this comment.
I don't think we have the linter set up for this, but missing trailing semicolon
| const { | ||
| disabled, | ||
| isWaiting, | ||
| waitingText, | ||
| children, | ||
| variant = 'primary', | ||
| variant, |
There was a problem hiding this comment.
Probably just me, but pushing it out makes it a bit longer to tell what the default is and do variant-y stuff inside the component in the future
There was a problem hiding this comment.
we're not able to set the default before its used in the styles, so having a default here seemed confusing (because it would only be defaulted within the component, not in the styles)
src/theme/buttons.ts
Outdated
|
|
||
| &:focus { | ||
| outline: solid ${set.outline}; | ||
| box-shadow: inset 0 0 0 3px ${set.shadow}; |
There was a problem hiding this comment.
This came from the original, but maybe a good time to use rem for consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more fixes for styling forms...
really we should do this in more places, by exporting the a styled component instead of a function component wrapping a styled component you allow that component to be used in selectors like
this for some reason doesn't work on the controlled form components that require context, because i guess styled tries to render the components when they're used in the css and that causes the context to throw.