update radio border color #53
Conversation
src/components/Radio.tsx
Outdated
| @@ -26,7 +26,7 @@ export const StyledInput = styled.input<{isDisabled?: boolean}>` | |||
| color: ${colors.palette.pale}; | |||
| width: 2rem; | |||
| height: 2rem; | |||
| border: 1px solid currentColor; | |||
| border: 1px solid #767676; | |||
There was a problem hiding this comment.
Is this value from UX? Like is this going to match new Figma stuff?
There was a problem hiding this comment.
There was a problem hiding this comment.
@bethshook @jivey I'm getting a hex of #767676 on the activity picker checkboxes in both Chrome and Edge, but it's possible those are the browser defaults. I assumed that color would be a simpler choice since it's already in use, but I didn't realize the boxes were left unstyled.
The original Figma designs use #6F6F6F. It's ideal to have production match, but I'm fine to use a different grey if that one's not in use — it just needs to be dark enough. It looks like a few greys are being used. Do you have a hex for the grey you're referencing or a link to your theme palette?
There was a problem hiding this comment.
@vcstax here is the palette. we can add #767676 or just use neutralThin. If we want we could also apply the same to checkboxes so we don't rely on browser defaults.
There was a problem hiding this comment.
@bethshook If #767676 isn't already being used, it doesn't need to be added. Since neutralThin (#6F6F6F) from the Figma designs is already being used elsewhere in production, it should be used for the update.
Ideally, the checkboxes would use this color as well since it matches the design and browser defaults may vary. That seems super low/no priority, though. We just need the radio border color update for accessibility.
No description provided.