Sidebar fixes #47
Merged
Sidebar fixes #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also improves some accessibility issues
jivey
commented
Aug 13, 2024
| @@ -24,6 +24,7 @@ export * from './components/Text'; | |||
| export * from './components/ToastContainer'; | |||
| export * from './components/Tooltip'; | |||
| export * as Forms from './components/forms'; | |||
| export * from './constants'; | |||
There was a problem hiding this comment.
This is unrelated but I need this for an assignments style.
|
looks good - that's a handy component |
bethshook
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/DISCO-29
@bethshook Tagging you on this one since you reviewed the initial sidebar PR. While I was looking into a fix for the re-rendering issue I saw (just needed a useCallback on the MaybeModal) I realized this could be a lot simpler by pulling in FocusScope instead of the modal approach. This feels less bug prone for remount and animation issues, and the toggle button no longer refocusing is a less confusing experience with a screen reader.