SidebarNav #45
Merged
SidebarNav #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethshook
reviewed
Aug 7, 2024
| } | ||
| } | ||
|
|
||
| @keyframes collapseSidebarNav { |
There was a problem hiding this comment.
why was animation necessary vs a transition?
There was a problem hiding this comment.
For mobile, I needed to remount it under a Modal, so the transition doesn't get a chance to play. This fakes the transition, running the expand on mount inside the modal and the collapse on normal mount. Thankfully it still worked too for the desktop case, though I'm realizing now I probably could have kept the transition for that case and kept the keyframe stuff only for mobile...
There was a problem hiding this comment.
ah of course, that makes sense
|
looks good in ladle, just left a question |
bethshook
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/DISCO-29