-
Notifications
You must be signed in to change notification settings - Fork 6
[テスト] DuskテストがChrome 134系になって出るエラーの修正 #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cate element with selector エラーになるためpress()で開く
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
上記の修正です。
対応
一部のDuskテストでエラーになった箇所に「画面表示がおいつかない場合があるので、ちょっと待つ」処理を追加して、対応しました。
修正後のgithub actions
https://github.com/opensource-workshop/connect-cms/actions/runs/13889293334
エラーが解消したことを確認しました。
推測上の原因
検証と推測をしたのですが、github actionsのブラウザがChrome 133 → 134 に変わったことで、ブラウザの画面表示が少し遅くなったようで、
ブラウザテストのプラグラム実行の方が早くなってしまい、ブラウザ画面表示をしきる前にボタン押下等の処理が走り、
一部のテストエラーが発生していたようです。
上記テストエラーは、ローカル環境で再現するものと、しないものがありました。
その点もテストしているPCやgithub actionsのサーバ環境の違いが影響しているかもしれません。
レビュー完了希望日
なし
関連Pull requests/Issues
概要に記載
参考
https://readouble.com/laravel/8.x/ja/dusk.html#assert-path-begins-with
https://qiita.com/tonnsama/items/2baca909d39dc9e23b07
DB変更の有無
無し
チェックリスト