[アイコン] fortawesome5→6へアップグレード OW-2522 #2137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
アイコン集の fortawesome を v5 から v6(6.7.2)にアップグレードしました。
v6には、v5 アイコン名のエイリアスが含まれていたため、既に使われているコードの修正なしでConnect-CMSに取り込めます。
修正後
ログイン後トップページ画面
→ 歯車等のアイコンが表示されることを確認しました
wiki/Font-Icon 修正
https://github.com/opensource-workshop/connect-cms/wiki/Font-Icon
※ 参考:修正前
npmライブラリ アップグレードコマンド
コマンド実行結果
github actionsでテスト
Laravel Dusk Connect-cms-test matrix · f72a5a4
https://github.com/opensource-workshop/connect-cms/actions/runs/13784633649
→ エラーなし
レビュー完了希望日
なし
関連Pull requests/Issues
参考
https://docs.fontawesome.com/web/setup/upgrade
https://docs.fontawesome.com/web/setup/upgrade/packages
https://docs.fontawesome.com/web/setup/upgrade/whats-changed#backward-compatibility
DB変更の有無
無し
チェックリスト