Skip to content

build(deps): bump league/commonmark from 1.6.7 to 2.6.1 & php7.4以上php8.1以下に変更 #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

akagane99
Copy link
Contributor

@akagane99 akagane99 commented Jan 15, 2025

概要

composerの league/commonmark に対するアップデート対応です。
league/commonmark の最新バージョン 2.6.1 がphp7.4以上からの対応だったため、当修正からphp7.4以上が必要になります。

レビュー完了希望日

なし

関連Pull requests/Issues

なし

参考

なし

DB変更の有無

なし

チェックリスト

@akagane99 akagane99 self-assigned this Jan 15, 2025
@akagane99 akagane99 added the developer update 開発者向けの更新 label Jan 15, 2025
@akagane99 akagane99 marked this pull request as ready for review January 15, 2025 05:39
@akagane99
Copy link
Contributor Author

akagane99 commented Jan 15, 2025

対応参考

動作確認

composer.lock、composer-dev.lockをupdate後、github actionsで動作確認しました。
各phpバージョンで問題なく動きそうです。
https://github.com/opensource-workshop/connect-cms/actions/runs/12782257415

追加対応:手順(他ライブラリも更新)

composer.lock

以下コマンドプロンプトで実施(win)

composer update

以下ターミナルで実施(linux)

composer update

composer-dev.lock

以下コマンドプロンプトで実施(win)

set COMPOSER=composer-dev.json
composer update

以下ターミナルで実施(linux)

COMPOSER=composer-dev.json composer update

@akagane99 akagane99 merged commit 59efbfb into master Jan 15, 2025
4 checks passed
@akagane99 akagane99 deleted the league/commonmark branch January 15, 2025 07:38
@akagane99
Copy link
Contributor Author

akagane99 commented Jan 15, 2025

wikiのinstallをphp7.4以上に修正しました。
https://github.com/opensource-workshop/connect-cms/wiki/Install

@akagane99 akagane99 changed the title build(deps): bump league/commonmark from 1.6.7 to 2.6.1 build(deps): bump league/commonmark from 1.6.7 to 2.6.1 & php7.4以上php8.1以下に変更 May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer update 開発者向けの更新
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant