CMA should support bound service account tokens #96335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
mburke5678
changed the title
|
@maxcao13 Can you PTAL? |
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL CUSTOM METRICS AUTOSCALER 2.17.2 RELEASES
https://issues.redhat.com/browse/OSDOCS-12581
Link to docs preview:
Understanding custom metrics autoscaler trigger authentications -- Added three example trigger authentications that use bound service account tokens. Moved example secret to after the associated trigger auth example.
Using trigger authentications -- Updated example trigger auth to use bound service token
Configuring the custom metrics autoscaler to use OpenShift Container Platform monitoring -- Updated example trigger auth to use bound service token; removed prereq to have a secret (not needed for new token)
QE review: