MCO OCL correct an annotation #96184
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Thu Jul 17 18:39:51 - Prow CI generated the docs preview: |
openshift-ci
bot
added
size/XS
mburke5678
force-pushed
the
fix-annotation
branch
from
8973f3e to
83eccf4
Compare
mburke5678
added
the
peer-review-needed
ShaunaDiaz
added
peer-review-in-progress
| @@ -10,4 +10,4 @@ To prevent the custom layered images from taking up excessive space in your regi | |||
|
|
|||
| The credentials provided by the registry push secret that you added to the `MachineOSBuild` object must grant the permission for deleting an image from the registry. If the delete permission is not provided, the image is not removed when you delete the `MachineOSBuild` object. | |||
|
|
|||
| Note that the custom layered image is not deleted if the image is either currently in use on a node or is desired by the nodes, as indicated by the `machineconfiguration.openshift.io/currentConfig` or `machineconfiguration.openshift.io/desiredConfig` annotation on the node. | |||
| Note that the custom layered image is not deleted if the image is either currently in use on a node or is desired by the nodes, as indicated by the `machineconfiguration.openshift.io/currentImage` or `machineconfiguration.openshift.io/desiredImage` annotation on the node, which are added to the node upon creating the `MachineOSConfig` object. | |||
There was a problem hiding this comment.
| Note that the custom layered image is not deleted if the image is either currently in use on a node or is desired by the nodes, as indicated by the `machineconfiguration.openshift.io/currentImage` or `machineconfiguration.openshift.io/desiredImage` annotation on the node, which are added to the node upon creating the `MachineOSConfig` object. | |
| The custom layered image is not deleted when the image is either currently in use on a node or is desired by the nodes, as indicated by the `machineconfiguration.openshift.io/currentImage` or `machineconfiguration.openshift.io/desiredImage` annotations on the node. Both annotations can be added to the node when you create the `MachineOSConfig` object. |
clearer, I think? not certain if the object is created by the user or is an automatic process, but you get the gist of what I am suggesting....
ShaunaDiaz
added
peer-review-done
mburke5678
force-pushed
the
fix-annotation
branch
from
83eccf4 to
e37ef6f
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
@mburke5678: new pull request created: #96300 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #96301 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
umohnani8 asked for this change in #96116 (comment). That PR is 4.18 only. This PR brings the change to
mainand 4.19+. Dev and QE reviews in original PR.Preview:
Removing an on-cluster custom layered image - Edited closing paragraph.
QE review: