Skip to content

OSDOCS-15304#Performance plus for Azure Disk #96181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Jul 16, 2025

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2025
@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.20 labels Jul 16, 2025
@lpettyjo lpettyjo added this to the Planned for 4.20 GA milestone Jul 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 16, 2025

@tmalove
Copy link
Contributor

tmalove commented Jul 16, 2025

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 16, 2025
@tmalove
Copy link
Contributor

tmalove commented Jul 16, 2025

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 16, 2025
Copy link

openshift-ci bot commented Jul 18, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Performance plus for Azure Disk has the following limitations:

* Can be enabled only on Standard HDD, Standard SSD, and Premium SSD managed disks that are 513 GiB or larger.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if a user asks for a smaller value the disk size will be rounded up to 513GiB

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's announce loudly in case the customers are surprised by the disk size.


:_mod-docs-content-type: PROCEDURE
[id="persistent-storage-csi-azure-disk-perf-plus-create-new-disk_{context}"]
= Enabling performance plus by creating new disks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed with OCP

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


* Can be enabled only on new disks.
+
*Workaround:* Create a snapshot of a disk that has performance plus enabled on it, and then create a new disk from the snapshot.
Copy link

@gcharot gcharot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we tested this @duanwei33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually we tested the following scenarios:

  1. The previous disk doesn't have performance plus enabled on it, and it is not impossible to enable performance plus on the existing disk.
  2. Create a snapshot of the existing disk and create a new disk from the snapshot with the storageclass which has parameter of enablePerformancePlus: "true"
  3. Or Clone a PVC of the existing disk with the storageclass which has parameter of enablePerformancePlus: "true".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh excellent thanks! We should document both options then!


:_mod-docs-content-type: PROCEDURE
[id="persistent-storage-csi-azure-disk-perf-plus-from-snapshots_{context}"]
= Creating new disks from existing disks or snapshots with performance plus enabled
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't work with OCP, this is for users who directly interact with Azure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


* Can be enabled only on new disks.
+
*Workaround:* Create a snapshot of a disk that has performance plus enabled on it, and then create a new disk from the snapshot.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually we tested the following scenarios:

  1. The previous disk doesn't have performance plus enabled on it, and it is not impossible to enable performance plus on the existing disk.
  2. Create a snapshot of the existing disk and create a new disk from the snapshot with the storageclass which has parameter of enablePerformancePlus: "true"
  3. Or Clone a PVC of the existing disk with the storageclass which has parameter of enablePerformancePlus: "true".


:_mod-docs-content-type: PROCEDURE
[id="persistent-storage-csi-azure-disk-perf-plus-create-new-disk_{context}"]
= Enabling performance plus by creating new disks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


:_mod-docs-content-type: PROCEDURE
[id="persistent-storage-csi-azure-disk-perf-plus-from-snapshots_{context}"]
= Creating new disks from existing disks or snapshots with performance plus enabled

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


Performance plus for Azure Disk has the following limitations:

* Can be enabled only on Standard HDD, Standard SSD, and Premium SSD managed disks that are 513 GiB or larger.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's announce loudly in case the customers are surprised by the disk size.

+
*Workaround:* Create a snapshot of a disk that has performance plus enabled on it, and then create a new disk from the snapshot.

* Not supported for disks recovered with Azure Site Recovery.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should we mention this? I don't think we need to cover "Azure Site Recovery".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh i think it's because it's mentioned as a limitation by microsoft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.20 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants