-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-15304#Performance plus for Azure Disk #96181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Fri Jul 18 17:50:15 - Prow CI generated the docs preview: https://96181--ocpdocs-pr.netlify.app/ |
/remove-label peer-review-needed |
modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc
Show resolved
Hide resolved
/remove-label peer-review-in-progress |
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
||
Performance plus for Azure Disk has the following limitations: | ||
|
||
* Can be enabled only on Standard HDD, Standard SSD, and Premium SSD managed disks that are 513 GiB or larger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that if a user asks for a smaller value the disk size will be rounded up to 513GiB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, let's announce loudly in case the customers are surprised by the disk size.
|
||
:_mod-docs-content-type: PROCEDURE | ||
[id="persistent-storage-csi-azure-disk-perf-plus-create-new-disk_{context}"] | ||
= Enabling performance plus by creating new disks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed with OCP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
||
* Can be enabled only on new disks. | ||
+ | ||
*Workaround:* Create a snapshot of a disk that has performance plus enabled on it, and then create a new disk from the snapshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we tested this @duanwei33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually we tested the following scenarios:
- The previous disk doesn't have performance plus enabled on it, and it is not impossible to enable performance plus on the existing disk.
- Create a snapshot of the existing disk and create a new disk from the snapshot with the storageclass which has parameter of enablePerformancePlus: "true"
- Or Clone a PVC of the existing disk with the storageclass which has parameter of enablePerformancePlus: "true".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh excellent thanks! We should document both options then!
|
||
:_mod-docs-content-type: PROCEDURE | ||
[id="persistent-storage-csi-azure-disk-perf-plus-from-snapshots_{context}"] | ||
= Creating new disks from existing disks or snapshots with performance plus enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't work with OCP, this is for users who directly interact with Azure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
||
* Can be enabled only on new disks. | ||
+ | ||
*Workaround:* Create a snapshot of a disk that has performance plus enabled on it, and then create a new disk from the snapshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually we tested the following scenarios:
- The previous disk doesn't have performance plus enabled on it, and it is not impossible to enable performance plus on the existing disk.
- Create a snapshot of the existing disk and create a new disk from the snapshot with the storageclass which has parameter of enablePerformancePlus: "true"
- Or Clone a PVC of the existing disk with the storageclass which has parameter of enablePerformancePlus: "true".
|
||
:_mod-docs-content-type: PROCEDURE | ||
[id="persistent-storage-csi-azure-disk-perf-plus-create-new-disk_{context}"] | ||
= Enabling performance plus by creating new disks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
||
:_mod-docs-content-type: PROCEDURE | ||
[id="persistent-storage-csi-azure-disk-perf-plus-from-snapshots_{context}"] | ||
= Creating new disks from existing disks or snapshots with performance plus enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
||
Performance plus for Azure Disk has the following limitations: | ||
|
||
* Can be enabled only on Standard HDD, Standard SSD, and Premium SSD managed disks that are 513 GiB or larger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, let's announce loudly in case the customers are surprised by the disk size.
+ | ||
*Workaround:* Create a snapshot of a disk that has performance plus enabled on it, and then create a new disk from the snapshot. | ||
|
||
* Not supported for disks recovered with Azure Site Recovery. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, should we mention this? I don't think we need to cover "Azure Site Recovery".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh i think it's because it's mentioned as a limitation by microsoft
Version(s): 4.20+
Issue: https://issues.redhat.com/browse/OSDOCS-15304
Link to docs preview: https://96181--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-azure.html#performance-plus-for-azure-disk
QE review:
Additional information:
PTAL: @gcharot @duanwei33 @jsafrane