Skip to content

OBSDOCS-1157: Fix instrumentation annotations in OTel docs #96097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OBSDOCS-1157: Fix instrumentation annotations in OTel docs #96097

wants to merge 1 commit into from
+8 −8

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Jul 15, 2025 •
edited
Loading

Version(s): OCP 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-1157

Link to docs preview:
https://96097--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-instrumentation.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2025 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-1157 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2025 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-1157 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): OCP 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-1157

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented Jul 15, 2025

This PR fixes remaining updates from #77259 and #81817.

@max-cx max-cx mentioned this pull request Jul 15, 2025
Closed
1 task
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 15, 2025 •
edited
Loading

🤖 Tue Jul 15 09:35:26 - Prow CI generated the docs preview:

https://96097--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-instrumentation.html

@max-cx max-cx force-pushed the OBSDOCS-1157-2025 branch from a2c94e0 to d650488 Compare July 15, 2025 09:27
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 15, 2025

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2025 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-1157 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): OCP 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-1157

Link to docs preview:
https://96097--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-instrumentation.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented Jul 15, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 15, 2025
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jul 15, 2025
ShaunaDiaz
ShaunaDiaz reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

Assignees

@ShaunaDiaz ShaunaDiaz

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@max-cx @openshift-ci-robot @ocpdocs-previewbot @ShaunaDiaz