Skip to content

OCPBUGS-58425 [NETOBSERV] Loki deployment namespace is not correct in the offical docs for netobserv #96084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jul 14, 2025

OCPBUGS-58425 [NETOBSERV] Loki deployment namespace is not correct in the offical docs for netobserv

Version(s):
4.12, 4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-58425

Link to docs preview:
https://96084--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/understanding-network-observability-operator.html#nw-network-observability-operator_nw-network-observability-operator

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 14, 2025

@Amoghrd
Copy link

Amoghrd commented Jul 15, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 15, 2025
@gwynnemonahan
Copy link
Contributor Author

Rebased morning 07/15/2025

Copy link

openshift-ci bot commented Jul 15, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 15, 2025
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion.

@@ -62,17 +62,16 @@ netobserv-ebpf-agent-xf5jh 1/1 Running 0 151m

`netobserv-ebpf-agent` pods monitor network interfaces of the nodes to get flows and send them to `flowlogs-pipeline` pods.

. If you are using the {loki-op}, check the status of pods running in the `openshift-operators-redhat` namespace by entering the following command:
. If you are using the {loki-op}, check the status of the `LokiStack` custom resource `component` pods running in the `netobserv` namespace by entering the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean "check the status of the component pods of LokiStack custom resource"? If yes, it can be rewritten. Also if component isn't a term used in code or name of the pod, backticks can be removed.

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants