Skip to content

CNV-62649: Update CNV modules to pass DITA validation #96074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhradilek
Copy link
Contributor

@jhradilek jhradilek commented Jul 14, 2025

Version(s): 4.19+

Issue: CNV-62649

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR should not require QE review as it focuses on content, does not change any meaning. This PR also focuses exclusively on modules and does not include assemblies to avoid being unnecessarily large. The PR may apply to older version, but I am not sure I am mentally prepared for manual cherry-picks all the way down to 4.14.

This is currently a draft. The following modules are yet to be updated as they require collaboration with some of the CNV writers:

  • modules/virt-expanding-vm-disk-pvc.adoc: There are two procedures in the same module.
  • modules/virt-must-gather-options.adoc: There are way too many block titles, this module could benefit from being split.
  • modules/virt-node-placement-rule-examples.adoc: There are too many examples, this module could benefit from being split.
  • modules/virt-updating-multiple-vms.adoc: There is a section in a procedure module.
  • modules/virt-viewing-network-state-of-node-console.adoc: There is a section in a procedure module.
  • modules/virt-virtctl-commands.adoc: This module is too complex and could benefit from being split.
  • modules/virt-defining-watchdog-device-vm.adoc: This module uses a block title which breaks conversion.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 14, 2025

@jhradilek: This pull request references CNV-62649 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-62649

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR should not require QE review as it focuses on content, does not change any meaning. This PR also focuses exclusively on modules and does not include assemblies to avoid being unnecessarily large. The PR may apply to older version, but I am not sure I am mentally prepared for manual cherry-picks all the way down to 4.14.

This is currently a draft. The following modules are yet to be updated as they require collaboration with some of the CNV writers:

  • modules/virt-expanding-vm-disk-pvc.adoc: There are two procedures in the same module.
  • modules/virt-must-gather-options.adoc: There are way too many block titles, this module could benefit from being split.
  • modules/virt-node-placement-rule-examples.adoc: There are too many examples, this module could benefit from being split.
  • modules/virt-updating-multiple-vms.adoc: There is a section in a procedure module.
  • modules/virt-viewing-network-state-of-node-console.adoc: There is a section in a procedure module.
  • modules/virt-virtctl-commands.adoc: This module is too complex and could benefit from being split.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jhradilek
Copy link
Contributor Author

/label cnv

@openshift-ci openshift-ci bot added CNV Label for all CNV PRs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2025

@jhradilek: This pull request references CNV-62649 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-62649

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR should not require QE review as it focuses on content, does not change any meaning. This PR also focuses exclusively on modules and does not include assemblies to avoid being unnecessarily large. The PR may apply to older version, but I am not sure I am mentally prepared for manual cherry-picks all the way down to 4.14.

This is currently a draft. The following modules are yet to be updated as they require collaboration with some of the CNV writers:

  • modules/virt-expanding-vm-disk-pvc.adoc: There are two procedures in the same module.
  • modules/virt-must-gather-options.adoc: There are way too many block titles, this module could benefit from being split.
  • modules/virt-node-placement-rule-examples.adoc: There are too many examples, this module could benefit from being split.
  • modules/virt-updating-multiple-vms.adoc: There is a section in a procedure module.
  • modules/virt-viewing-network-state-of-node-console.adoc: There is a section in a procedure module.
  • modules/virt-virtctl-commands.adoc: This module is too complex and could benefit from being split.
  • modules/virt-defining-watchdog-device-vm.adoc: This module uses a block title which breaks conversion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CNV Label for all CNV PRs do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants