HCIDOCS-729-v416: Replace corrupt links v416 #96070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
🤖 Mon Jul 14 16:07:05 - Prow CI generated the docs preview: |
|
@tshwartz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/remove-label peer-review-needed |
openshift-ci
bot
added
peer-review-in-progress
tmalove
approved these changes
Jul 14, 2025
| @@ -33,11 +33,11 @@ For the full procedure, see link:https://docs.oracle.com/en-us/iaas/Content/Obje | |||
| + | |||
| [IMPORTANT] | |||
| ==== | |||
| The Terraform stack includes files for creating cluster resources and custom manifests. The stack also includes a script, and when you apply the stack, the script creates {oci} resources, such as DNS records, an instance, and so on. For a list of the resources, see link:https://github.com/oracle-openshift/oci-openshift/blob/main/terraform-stacks/README.md[Terraform Defined Resources for OpenShift on {oci} README file]. | |||
| The Terraform stack includes files for creating cluster resources and custom manifests. The stack also includes a script, and when you apply the stack, the script creates {oci} resources, such as DNS records, an instance, and so on. For a list of the resources, see the `terraform-stacks` folder in link:https://github.com/oracle-quickstart/oci-openshift/tree/main[OpenShift on OCI (OSO)]. | |||
There was a problem hiding this comment.
Suggested change
| The Terraform stack includes files for creating cluster resources and custom manifests. The stack also includes a script, and when you apply the stack, the script creates {oci} resources, such as DNS records, an instance, and so on. For a list of the resources, see the `terraform-stacks` folder in link:https://github.com/oracle-quickstart/oci-openshift/tree/main[OpenShift on OCI (OSO)]. | |
| The Terraform stack includes files for creating cluster resources and custom manifests. The stack also includes a script, and when you apply the stack, the script creates {oci} resources, such as DNS records, an instance, and other resources. For a list of the resources, see the `terraform-stacks` folder in link:https://github.com/oracle-quickstart/oci-openshift/tree/main[OpenShift on OCI (OSO)]. |
See ISG: https://www.ibm.com/docs/en/ibm-style?topic=word-usage#a
Suggested 'resources' as an option, but another term that you think is more accurate will be good.
|
/remove-label peer-review-in-progress Direct preview link. |
openshift-ci
bot
added
peer-review-done
|
Thanks for your review @tmalove . I will not make the change here because I would like v4.16 to be the same as the later versions already published here (#95211). I have created a bug for it instead: https://issues.redhat.com/browse/HCIDOCS-760 and hope that's OK. Please let me know. Thanks! |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
@tshwartz I'm OK with that Talia...thanks for letting me know. |
bscott-rh
added
merge-review-in-progress
bscott-rh
reviewed
Jul 15, 2025
| ==== | ||
| + | ||
| -- | ||
| .. Upload the Terraform stack template link:https://github.com/oracle-openshift/oci-openshift/releases/tag/main[create-cluster-vX.X.X.zip] to the new object storage bucket. | ||
| .. Upload the Terraform stacks template link:https://github.com/oracle-quickstart/oci-openshift/tree/main/terraform-stacks[terrform-stacks] to the new object storage bucket. |
There was a problem hiding this comment.
Suggested change
| .. Upload the Terraform stacks template link:https://github.com/oracle-quickstart/oci-openshift/tree/main/terraform-stacks[terrform-stacks] to the new object storage bucket. | |
| .. Upload the Terraform stacks template link:https://github.com/oracle-quickstart/oci-openshift/tree/main/terraform-stacks[terraform-stacks] to the new object storage bucket. |
bscott-rh
approved these changes
Jul 15, 2025
bscott-rh
added
branch/enterprise-4.16
and removed
merge-review-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s):
4.16
Issue:
https://issues.redhat.com/browse/HCIDOCS-729
Link to docs preview:
QE review:
Additional information:
Approved and published for version 4.17 and later (#95211), but I missed version 4.16.