Skip to content

CNV#50733: OCV Operator installation via CLI doesn't include the label openshift.io/cluster-monitoring: "true" in the ns/openshift-cnv #95865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

CNV#50733: OCV Operator installation via CLI doesn't include the label openshift.io/cluster-monitoring: "true" in the ns/openshift-cnv #95865

merged 1 commit into from
Jul 17, 2025
+2 −0

Conversation

aspauldi
Copy link

@aspauldi aspauldi commented Jul 9, 2025 •
edited
Loading

Version(s): 4.14+

Issue: CNV-50733

Link to docs preview: Subscribing to the OpenShift Virtualization catalog by using the CLI

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Jul 09 20:39:00 - Prow CI generated the docs preview:

https://95865--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/installing-virt.html
https://95865--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/install/installing-virt.html
https://95865--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/install/installing-virt.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

@aspauldi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aspauldi
Copy link
Author

aspauldi commented Jul 9, 2025 •
edited
Loading

Hello @rarosaAU! Can you please review this correction for the bug fix you reported? Thanks!

@rarosaAU
Copy link

Perfect! Thank you, @aspauldi

@lkladnit
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2025
@aspauldi
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 14, 2025
@aspauldi
Copy link
Author

/label CNV

@openshift-ci openshift-ci bot added the CNV Label for all CNV PRs label Jul 14, 2025
@lcavalle
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 15, 2025
@lcavalle
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 15, 2025
@lcavalle
Copy link
Contributor

LGTM!

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 15, 2025
@aspauldi
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 16, 2025
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 17, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone Jul 17, 2025
skopacz1
skopacz1 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@skopacz1 skopacz1 merged commit a144257 into openshift:main Jul 17, 2025
2 checks passed
@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96268

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96269

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96270

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96271

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96272

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96273

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Open
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #96274

In response to this:

/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees

@lkladnit lkladnit

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 CNV Label for all CNV PRs lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@aspauldi @ocpdocs-previewbot @rarosaAU @lkladnit @lcavalle @skopacz1 @openshift-cherrypick-robot