-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS#15321] Remove all unused topics dir files #95773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Tue Jul 15 19:14:30 - Prow CI generated the docs preview: |
cba9315
to
63f5de7
Compare
@maxwelldb: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can potentially see leaving a modified version of this plus _unused_topics as info + placeholder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it's fine to remove this directory/README too. I don't think we should be using it or adding more files to it before we migrate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for MicroShift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it's fine to remove this directory/README too. I don't think we should be using it or adding more files to it before we migrate.
This PR deletes all items in the main branch that exist in _unused_topics.
Version(s): 4.20+ by necessity until more scrutiny happens.
Issue: OSDOCS-15321
Link to docs preview: n/a
QE review:QE has approved this change.Additional information: