Skip to content

CNV-62383: CPU/memory hotplug limitations #95592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2025

@sbeskin-redhat: This pull request references CNV-62383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-62383

CNV 4.17+
OCP 4.17+

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2025

@sbeskin-redhat: This pull request references CNV-62383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-62383

CNV 4.17+
OCP 4.17+

Preview:
https://95592--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-memory_virt-edit-vms
https://95592--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-cpu_virt-edit-vms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sbeskin-redhat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 9, 2025
+
[NOTE]
====
You can hot-plug up to 3 times the default initial amount of memory of the VM. Exceeding this limit requires a restart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can hot-plug up to 3 times the default initial amount of memory of the VM. Exceeding this limit requires a restart.
You can hot-plug up to three times the default initial number of vCPU sockets of the VM without a restart. Exceeding this limit requires a restart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mburke5678
Thank you!
I spelled out "3". But the meaning of "hot-plug" is "without a restart", so another "without a restart" would be redundant.

@mburke5678
Copy link
Contributor

@sbeskin-redhat A couple of comments for your consideration. Feel free to ignore.

@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 9, 2025
@sbeskin-redhat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 10, 2025
@sbeskin-redhat sbeskin-redhat force-pushed the CNV_62383_cpu_memory_hotplug_limitations branch from 9a272d0 to 0f2cc9c Compare July 10, 2025 12:33
Copy link

openshift-ci bot commented Jul 10, 2025

@sbeskin-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 10, 2025
@kcarmichael08
Copy link
Contributor

Hi @sbeskin-redhat - I think this would need a QE ack before it can be merged. (I see that Sean said it was good on the Jira - is his approval considered a QE ack? If so can you please indicate in the PR?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants