-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CNV-62383: CPU/memory hotplug limitations #95592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CNV-62383: CPU/memory hotplug limitations #95592
Conversation
@sbeskin-redhat: This pull request references CNV-62383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sbeskin-redhat: This pull request references CNV-62383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
+ | ||
[NOTE] | ||
==== | ||
You can hot-plug up to 3 times the default initial amount of memory of the VM. Exceeding this limit requires a restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can hot-plug up to 3 times the default initial amount of memory of the VM. Exceeding this limit requires a restart. | |
You can hot-plug up to three times the default initial number of vCPU sockets of the VM without a restart. Exceeding this limit requires a restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mburke5678
Thank you!
I spelled out "3". But the meaning of "hot-plug" is "without a restart", so another "without a restart" would be redundant.
@sbeskin-redhat A couple of comments for your consideration. Feel free to ignore. |
/label merge-review-needed |
9a272d0
to
0f2cc9c
Compare
@sbeskin-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hi @sbeskin-redhat - I think this would need a QE ack before it can be merged. (I see that Sean said it was good on the Jira - is his approval considered a QE ack? If so can you please indicate in the PR?) |
Resolves: https://issues.redhat.com/browse/CNV-62383
CNV 4.17+
OCP 4.17+
Preview:
https://95592--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-memory_virt-edit-vms
https://95592--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-cpu_virt-edit-vms