#CNV -62298 - CPU hotplug with networkInterfaceMultiqueue enabled #95585
Conversation
openshift-ci
bot
added
the
size/XS
Vaishali-gif-rh
force-pushed
the
CNV-62298
branch
from
e29f70f to
e4dc80c
Compare
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
Thank you for the changes @Vaishali-gif-rh! |
Vaishali-gif-rh
force-pushed
the
CNV-62298
branch
from
e4dc80c to
f77b03d
Compare
|
@orelmisan - done |
|
/remove-label peer-review-needed /label peer-review-in-progress |
openshift-ci
bot
added
peer-review-in-progress
There was a problem hiding this comment.
Added a few small suggestions, thank you!
/remove-label peer-review-in-progress
/label peer-review-done
Edit: Also please add the link to previw to the first comment: https://95585--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-cpu_virt-edit-vms
Thanks!
openshift-ci
bot
added
peer-review-done
Vaishali-gif-rh
force-pushed
the
CNV-62298
branch
from
f77b03d to
d92750b
Compare
|
@Vaishali-gif-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
dfitzmau
added
merge-review-in-progress
| @@ -19,3 +19,12 @@ You can increase or decrease the number of CPU sockets allocated to a virtual ma | |||
| + | |||
| If the VM is migratable, a live migration is triggered. If not, or if the changes cannot be live-updated, a `RestartRequired` condition is added to the VM. | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| If a VM has the `spec.template.spec.domain.devices.networkInterfaceMultiQueue` field enabled and CPUs are hot-plugged, the following behavior occurs: | |||
There was a problem hiding this comment.
| If a VM has the `spec.template.spec.domain.devices.networkInterfaceMultiQueue` field enabled and CPUs are hot-plugged, the following behavior occurs: | |
| If a VM has the `spec.template.spec.domain.devices.networkInterfaceMultiQueue` field enabled and CPUs are hot plugged, the following behavior occurs: |
I'm basing this on doc repo searches for similar examples. The hyphen form would need to a closing noun.
| * Existing network interfaces that you attach before the CPU hot plug retain their original queue count, even after you add more virtual CPUs (vCPUs). The underlying virtualization technology causes this expected behavior. | ||
| * To update the queue count of existing interfaces to match the new vCPU configuration, you can restart the VM. A restart is only necessary if the update improves performance. | ||
| * New VirtIO network interfaces that you hot-plug after the CPU hot plug automatically receive a queue count that matches the updated vCPU configuration. |
There was a problem hiding this comment.
| * New VirtIO network interfaces that you hot-plug after the CPU hot plug automatically receive a queue count that matches the updated vCPU configuration. | |
| * New VirtIO network interfaces that you hot plugged after the CPU hotplug automatically receive a queue count that matches the updated vCPU configuration. |
There was a problem hiding this comment.
Verb form is two words. See https://redhat-documentation.github.io/supplementary-style-guide/#hot-plug
|
Hi @Vaishali-gif-rh . Nice work. I added some minor clarifications for "hot plug". Would you be OK to take a look? |
Version(s):
4.18+
Issue:
https://issues.redhat.com/browse/CNV-62298
Link to docs preview:
QE review:
Additional information: