-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OADP-5967-prometheus support #95469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OADP-5967-prometheus support #95469
Conversation
/label OADP |
🤖 Fri Jul 04 09:46:50 - Prow CI generated the docs preview: |
@mpryc @stillalearner - Can I please ask for your review for this PR? Thanks. |
@shdeshpa07 Would it make sense to remove the part starting from: I've reviewed again the metrics and to be very precise on what's available I would like some modifications to be made:
The above metric is type of histogram, which in the OpenShift Monitoring is really giving us a collection of 3 separate metrics:
End ending with
Would it make sense to remove some parts in favor of simply pointing to different chapted of the same OpenShift docs? Possibly having them here gives a full end-to-end set of instructions ?
|
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
ef70f28
to
55ce7bd
Compare
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@mpryc - Thank you for the review.
Could you please review again to see if the changes look good? Thanks. |
@shdeshpa07: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@shdeshpa07 everything looks perfect except one nit, the following link is a plain text not a hyperlink in the generated docs:
|
Thank you @mpryc . The link has a {ocp_latest_version} attribute in it and hence it will resolve only in the production depolyment. You will be able to see the resolved link in the production docs. Thanks. |
/label peer-review-needed |
/lgtm |
Hi @shdeshpa07 . Please squash the commits from 4 down to 1. |
@@ -64,7 +64,7 @@ servicemonitor.monitoring.coreos.com/oadp-service-monitor created | |||
|
|||
.Verification | |||
|
|||
* Confirm that the new service monitor is in an *Up* state by using the *Administrator* perspective of the {product-title} web console: | |||
* Confirm that the new service monitor is in an *Up* state by using the *Administrator* perspective of the {product-title} web console. It takes a few minutes for the service monitor to be in the *Up* state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to define "it" as it's a vague referent. How about:
Wait a few minutes for the service monitor to reach the Up state.
| `velero_restore_success_total` | Total number of successful restores | Counter | ||
| `velero_restore_partial_failure_total` | Total number of partially failed restores | Counter | ||
| `velero_restore_failed_total` | Total number of failed restores | Counter | ||
| `velero_volume_snapshot_attempt_total``| Total number of attempted volume snapshots | Counter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
volume_snapshot_attempt_total` has an extra backtick.
Jira
Add note about support for Promethues metric and remove unsupported velero metrics
Version
Preview
Note for prometheus support
List of available metrics
QE Review