Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95410

prithvipatil97 · 2025-06-28T13:15:56Z

Incorrect structure in the OpenShift documentation
Here is the documentation link: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/storage/ephemeral-storage-csi-vol-detach-non-graceful-shutdown#persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure_ephemeral-storage-csi-vol-detach-non-graceful-shutdown
$ sign is missing from every command.
is mentioned without an underscore.

Following changes are required:

Need to add $ sign at the start of each command.
Need to mention underscore between
Need to add <node_name> value for 1

Version(s):

RHOCP 4.20, RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16, RHOCP 4.15, RHOCP 4.14, RHOCP 4.13

Issue:

https://issues.redhat.com/browse/OBSDOCS-2047

Link to docs preview:

QE review:

QE has approved this change.

https://95410--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent-storage-csi-vol-detach-non-graceful-shutdown.html

Additional information:

ocpdocs-previewbot · 2025-06-28T13:20:49Z

🤖 Tue Jul 01 13:12:56 - Prow CI generated the docs preview:

https://95410--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent-storage-csi-vol-detach-non-graceful-shutdown.html

prithvipatil97 · 2025-06-28T13:22:22Z

/label peer-review-needed

aspauldi · 2025-06-30T17:11:56Z

/label peer-review-in-progress

modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc

aspauldi · 2025-06-30T17:26:05Z

Hi, I added a suggestion for rewording the callout text, hoping to make it less awkward. (I realize though that your update was just to use the underscore, so consider the rewrite but I understand if you prefer not to make the changes.)

Overall LGTM!

aspauldi · 2025-06-30T17:26:45Z

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

eohartman · 2025-06-30T17:32:52Z

Make sure to add the link to the preview in your description. Thank you!

…ure.adoc - Incorrect structure in the OpenShift documentation - Here is the documentation link: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/storage/ephemeral-storage-csi-vol-detach-non-graceful-shutdown#persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure_ephemeral-storage-csi-vol-detach-non-graceful-shutdown -$ sign is missing from every command. - <node name> is mentioned without an underscore. Following changes are required: 1. Need to add $ sign at the start of each command. 2. Need to mention underscore between <node name> 3. Need to add <node_name> value for 1 Newcommit-Update persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Newcommit-Update persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc

openshift-ci · 2025-07-01T13:13:57Z

@prithvipatil97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

prithvipatil97 · 2025-07-02T21:24:18Z

Hello @eohartman ,
Thanks for the peer review and suggestions.
I have successfully committed the suggested changes.
Now, I will ask for QE approval.

Regards,
Prithviraj Patil

prithvipatil97 · 2025-07-02T21:26:08Z

Hello Team,
I need QE approval for this change.

All checks have passed, and Peer review is also done.

It would be really helpful if someone could please take a look and provide QE approval for this change.

cc: @Phaow @duanwei33, @ropatil010

Regards,
Prithviraj Patil

ropatil010 · 2025-07-09T05:09:10Z

/lgtm

prithvipatil97 · 2025-07-09T12:56:56Z

/label merge-review-needed

mburke5678 · 2025-07-09T19:08:15Z

/cherrypick enterprise-4.13
/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

openshift-cherrypick-robot · 2025-07-09T19:09:03Z

@mburke5678: #95410 failed to apply on top of branch "enterprise-4.13":

Applying: Update persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
Using index info to reconstruct a base tree...
M	modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
CONFLICT (content): Merge conflict in modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc

In response to this:

/cherrypick enterprise-4.13
/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mburke5678 · 2025-07-09T19:18:30Z

/cherrypick enterprise-4.14

openshift-cherrypick-robot · 2025-07-09T19:19:16Z

@mburke5678: #95410 failed to apply on top of branch "enterprise-4.14":

Applying: Update persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
Using index info to reconstruct a base tree...
M	modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
CONFLICT (content): Merge conflict in modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mburke5678 · 2025-07-09T19:33:41Z

/cherrypick enterprise-4.15

mburke5678 · 2025-07-09T19:33:45Z

/cherrypick enterprise-4.16

mburke5678 · 2025-07-09T19:33:48Z

/cherrypick enterprise-4.17

mburke5678 · 2025-07-09T19:33:52Z

/cherrypick enterprise-4.18

mburke5678 · 2025-07-09T19:33:57Z

/cherrypick enterprise-4.19

mburke5678 · 2025-07-09T19:34:04Z

/cherrypick enterprise-4.20

openshift-cherrypick-robot · 2025-07-09T19:34:31Z

@mburke5678: new pull request created: #95851

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-07-09T19:34:36Z

@mburke5678: new pull request created: #95852

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-07-09T19:34:41Z

@mburke5678: new pull request created: #95853

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-07-09T19:34:44Z

@mburke5678: new pull request created: #95854

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-07-09T19:34:50Z

@mburke5678: new pull request created: #95855

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-07-09T19:34:56Z

@mburke5678: new pull request created: #95856

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 28, 2025

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 28, 2025

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 30, 2025

aspauldi reviewed Jun 30, 2025

View reviewed changes

modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Outdated Show resolved Hide resolved

aspauldi reviewed Jun 30, 2025

View reviewed changes

modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Outdated Show resolved Hide resolved

aspauldi reviewed Jun 30, 2025

View reviewed changes

modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Outdated Show resolved Hide resolved

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 30, 2025

prithvipatil97 force-pushed the patch-69 branch from 763b432 to 2efdcb2 Compare July 1, 2025 13:00

openshift-ci bot assigned ropatil010 Jul 9, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 9, 2025

mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 labels Jul 9, 2025

mburke5678 added branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 labels Jul 9, 2025

mburke5678 merged commit bebce35 into openshift:main Jul 9, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Jul 9, 2025

[enterprise-4.15] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95851

Merged

openshift-cherrypick-robot mentioned this pull request Jul 9, 2025

[enterprise-4.16] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95852

Merged

openshift-cherrypick-robot mentioned this pull request Jul 9, 2025

[enterprise-4.17] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95853

Merged

openshift-cherrypick-robot mentioned this pull request Jul 9, 2025

[enterprise-4.18] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95854

Merged

openshift-cherrypick-robot mentioned this pull request Jul 9, 2025

[enterprise-4.19] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95855

Merged

openshift-cherrypick-robot mentioned this pull request Jul 9, 2025

[enterprise-4.20] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95856

Open

mburke5678 mentioned this pull request Jul 9, 2025

[enterprise-4.14] Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced #95857

Merged

mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 9, 2025

Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95410

Update persistent-storage-csi-vol-detach-non-graceful-shutdown-proced… #95410

Uh oh!

Conversation

prithvipatil97 commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prithvipatil97 commented Jun 28, 2025

Uh oh!

aspauldi commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aspauldi commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aspauldi commented Jun 30, 2025

Uh oh!

eohartman commented Jun 30, 2025

Uh oh!

openshift-ci bot commented Jul 1, 2025

Uh oh!

prithvipatil97 commented Jul 2, 2025

Uh oh!

prithvipatil97 commented Jul 2, 2025

Uh oh!

ropatil010 commented Jul 9, 2025

Uh oh!

prithvipatil97 commented Jul 9, 2025

Uh oh!

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

mburke5678 commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 9, 2025

Uh oh!

Uh oh!

prithvipatil97 commented Jun 28, 2025 •

edited

Loading

ocpdocs-previewbot commented Jun 28, 2025 •

edited

Loading

aspauldi commented Jun 30, 2025 •

edited

Loading