Skip to content

OCPBUGS#58128: Tweaked the nw-egress-ips-multi-nic-considerations .ad… #95351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS#58128: Tweaked the nw-egress-ips-multi-nic-considerations .ad… #95351

wants to merge 1 commit into from
+5 −19

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jun 27, 2025 •
edited
Loading

Version(s):
4.14+

Issue:
OCPBUGS-58128

Link to docs preview:

  • SME has approved this change (Tim Rozet).
  • QE has approved this change (Jean Chen).

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-58128, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-58128

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2025
@dfitzmau dfitzmau changed the title OCPBUGS-58128: Tweaked the nw-egress-ips-multi-nic-considerations .ad… OCPBUGS#58128: Tweaked the nw-egress-ips-multi-nic-considerations .ad… Jun 27, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2025
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-58128

Link to docs preview:
4.14+

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 27, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 27, 2025 •
edited
Loading

🤖 Tue Jul 15 16:27:46 - Prow CI generated the docs preview:

https://95351--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.html
https://95351--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.html

trozet
trozet reviewed Jun 27, 2025
View reviewed changes
@trozet
Copy link

trozet commented Jul 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 14, 2025
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 14, 2025
skopacz1
skopacz1 approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done!

@skopacz1 skopacz1 added this to the Continuous Release milestone Jul 14, 2025
@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 14, 2025
jechen0648
jechen0648 reviewed Jul 15, 2025
View reviewed changes
modules/nw-egress-ips-about.adoc Outdated
ipForwarding: Global
# ...
----
* If you have configured a secondary network interface card (NIC) that acts as the Egress IP interface for nodes in your cluster, you used the Node Tuning Operator to enable IP forwarding for the secondary NIC.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use egressIP on a secondary network interface (NIC), you need to enable IP forwarding for the secondary NIC, this can be done using Node Tuning Operator

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 15, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jechen0648
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jechen0648 jechen0648 jechen0648 left review comments

@trozet trozet trozet approved these changes

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees

@trozet trozet

@jechen0648 jechen0648

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @trozet @jechen0648 @skopacz1