-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Mod docs for Virt #95330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mod docs for Virt #95330
Conversation
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@shdeshpa07: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label OADP |
/label peer-review-needed |
@@ -4,6 +4,8 @@ | |||
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-kubevirt.adoc | |||
|
|||
:_mod-docs-content-type: SNIPPET | |||
|
|||
[role="_abstract"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The role="_abstract"] tag is also needed for a snippet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the vale package throws an error. It says you need the tag for the para to convert to a . Thanks for the review! Appreciate the help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not an error, but a suggestion
.
Jira
This PR is for changes found by running the ASCIIDocDITA vale package for the
Configuring OADP on Virt
doc set.This PR has structural changes only. No technical changes have been made.
Peer/Merge reviewer - Please review the PR from the POV of structural-changes only. The PR has only structural changes. Which means, no content has been newly added/modfied and there are no technical changes. Content is moved around to make it compatible for DITA migration.
cc: @kalexand-rh
Version
QE Review
By-passing QE review for this PR as the changes are structural only.