Skip to content

OADP-1791: Added suggestions for the backup types #93556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

OADP-1791: Added suggestions for the backup types #93556

wants to merge 3 commits into from

Conversation

apurvabhide17
Copy link
Contributor

@apurvabhide17 apurvabhide17 commented May 19, 2025 •
edited
Loading

Version(s):
4.14-4.18

Issue:
OADP-1791

Link to docs preview: Backing up applications

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025 •
edited by openshift-ci bot
Loading

@apurvabhide17: This pull request references OADP-1791 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.14-4.18

Issue:
OADP-1791

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apurvabhide17
Copy link
Contributor Author

/label OADP

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 19, 2025 •
edited
Loading

🤖 Fri Jun 06 19:25:45 - Prow CI generated the docs preview:

https://93556--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html
https://93556--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html
https://93556--ocpdocs-pr.netlify.app/openshift-rosa/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html

@apurvabhide17 apurvabhide17 force-pushed the OADP-1791-backing-up-applications branch from 94134e7 to 3286da5 Compare May 20, 2025 05:27
@apurvabhide17 apurvabhide17 force-pushed the OADP-1791-backing-up-applications branch from 3286da5 to 53d10ee Compare May 20, 2025 07:41
shdeshpa07
shdeshpa07 reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@shdeshpa07 shdeshpa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small nit.

@apurvabhide17 apurvabhide17 force-pushed the OADP-1791-backing-up-applications branch from 53d10ee to 3a6881d Compare May 20, 2025 11:28
@apurvabhide17
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025 •
edited by openshift-ci bot
Loading

@apurvabhide17: This pull request references OADP-1791 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.14-4.18

Issue:
OADP-1791

Link to docs preview: Backing up applications

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aravipra
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 20, 2025
@aravipra
Copy link
Contributor

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 20, 2025
@aravipra
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 20, 2025
@aravipra
Copy link
Contributor

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label May 20, 2025
@aravipra
Copy link
Contributor

@apurvabhide17 please wait for my comments to be double checked as I am new to peer review.
@agantony please review the comments.

agantony
agantony reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted a few style guide issues; overall lgtm!

@apurvabhide17 apurvabhide17 force-pushed the OADP-1791-backing-up-applications branch from 146be44 to d80def9 Compare June 5, 2025 17:32
PrasadJoshi12
PrasadJoshi12 reviewed Jun 6, 2025
View reviewed changes
...restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.adoc Outdated

ifdef::openshift-rosa,openshift-rosa-hcp[]
The `Backup` CR creates backup files for Kubernetes resources and internal images on S3 object storage.
endif::openshift-rosa,openshift-rosa-hcp[]

ifndef::openshift-rosa,openshift-rosa-hcp[]
* The `Backup` CR creates backup files for Kubernetes resources and internal images on S3 object storage.

* In an on-cluster backup, you back up the persistent volume data within the cluster. This type of backup is fast, and you can execute it frequently; however, the data is vulnerable to cluster or storage outages. You can use Container Storage Interface (CSI) volume snapshots for an on-cluster backup.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshayutin @apurvabhide17 I'm thinking change it to something like this

if you use velero's snapshot feature to backup volumes in that case only snapshot related information is stored in s3 bucket along with the openshift object data. If undelying storage is part of same cluster infra then data might be loss in case of disaster.  Same for bucket if bucket is part of the same cluster then all backup data will be lost in case of disaster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've added this information and removed everything else related to in/off cluster.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 6, 2025

@apurvabhide17: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vashirova vashirova mentioned this pull request Jul 15, 2025
Open
1 task
@raoradhika
Copy link

@apurvabhide17 lets close this PR since Valentina is working on this one in #96098. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin left review comments

@agantony agantony agantony left review comments

@PrasadJoshi12 PrasadJoshi12 PrasadJoshi12 left review comments

@aravipra aravipra aravipra left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@shdeshpa07 shdeshpa07 shdeshpa07 left review comments

@Pkylas007 Pkylas007 Pkylas007 left review comments

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.