Skip to content

OSDOCS-14356-New: Added bond best practices info to networking docs #93160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented May 8, 2025

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2025
@dfitzmau dfitzmau force-pushed the OSDOCS-14356-new branch from 18241e1 to 8846ca5 Compare May 8, 2025 16:03
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2025
@dfitzmau dfitzmau force-pushed the OSDOCS-14356-new branch from 8846ca5 to d6452ad Compare May 8, 2025 16:06
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 8, 2025

🤖 Wed Jul 09 11:39:08 - Prow CI generated the docs preview:
https://93160--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@@ -7,6 +7,11 @@

You can create multiple interfaces in the same node network configuration policy. These interfaces can reference each other, allowing you to build and deploy a network configuration by using a single policy manifest.

[IMPORTANT]
====
If multiple interfaces use the same default configuration, a single Network Manager connection profile activates on multiple interfaces simultaneously and this causes connections to have the same universally unique identifier (UUID). To avoid this issue, ensure that each interface has a specific configuration that is different to the default configuration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'different from' rather than 'different to'. For more information, see RedHat.TermsErrors.

@dfitzmau dfitzmau force-pushed the OSDOCS-14356-new branch 2 times, most recently from 3296fa2 to 318fd00 Compare May 9, 2025 08:21
@dfitzmau
Copy link
Contributor Author

/retest

@dfitzmau dfitzmau force-pushed the OSDOCS-14356-new branch from 318fd00 to 1b5443b Compare July 9, 2025 11:27
Copy link

openshift-ci bot commented Jul 9, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[NOTE]
====
* It is recommended to use a DHCP server for long-term management of the cluster machines. Ensure that the DHCP server is configured to provide persistent IP addresses, DNS server information, and hostnames to the cluster machines.
* Use a DHCP server for long-term management of the cluster machines. Ensure that the DHCP server is configured to provide persistent IP addresses, DNS server information, and hostnames to the cluster machines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what our doc guidelines say, but to me this change indicates that a DHCP server is mandatory, which is contradicted by the next point in this note.

@@ -266,7 +279,6 @@ Optional: You can configure VLANs on bonded interfaces by using the `vlan=` para

[source,terminal]
----
ip=bond0.100:dhcp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these lines being removed?

@@ -235,7 +248,7 @@ information for the bonded interface.
[source,terminal]
----
bond=bond0:em1,em2:mode=active-backup
ip=bond0:dhcp
fail_over_mac=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unsupported value for fail_over_mac.

Also, this won't work as written. It needs to be part of the colon-separated list on the bond= line. That said, the default value is 0, which is what we recommend anyway, so I'm not sure we even need to explicitly include this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants