-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS #34373: Added a note in creating the externally managed certificate section #92978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: routes/custom-host
is a sub-resource
/lgtm
/cc @lihongan
/assign @snarayan-redhat |
@subhtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
LGTM expect one suggestion We need also add the same note in cert-manager's section (incert at L16): @snarayan-redhat It's up to you if make changes in this PR or create another one! |
@chiragkyal do you think there is an overlap between the note we are going to add and the one of existing Prerequisites:
|
There is a bit of an overlap, I agree. I'm fine updating the existing prerequisites with the two bullets we're adding in the Notes, if that helps keep things consistent enough. |
Closing this PR since following up in PR #96060 |
Version(s): 4.18+
Issue: https://issues.redhat.com/browse/OCPBUGS-34373
Link to docs preview: https://92978--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/routes/secured-routes.html#nw-ingress-route-secret-load-external-cert_secured-routes
QE review:
Additional information: