Skip to content

OCPBUGS #34373: Added a note in creating the externally managed certificate section #92978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

subhtk
Copy link
Contributor

@subhtk subhtk commented May 5, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2025
Copy link
Member

@chiragkyal chiragkyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: routes/custom-host is a sub-resource
/lgtm
/cc @lihongan

@openshift-ci openshift-ci bot requested a review from lihongan May 5, 2025 05:46
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025
@chiragkyal
Copy link
Member

/assign @snarayan-redhat
For traction

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
Copy link

openshift-ci bot commented Jul 8, 2025

@subhtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chiragkyal
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@lunarwhite
Copy link
Member

LGTM expect one suggestion

We need also add the same note in cert-manager's section (incert at L16):

@snarayan-redhat It's up to you if make changes in this PR or create another one!

@lunarwhite
Copy link
Member

lunarwhite commented Jul 8, 2025

@chiragkyal do you think there is an overlap between the note we are going to add and the one of existing Prerequisites:

* You must have the `create` and `update` permissions on the `routes/custom-host`.

@chiragkyal
Copy link
Member

@chiragkyal do you think there is an overlap between the note we are going to add and the one of existing Prerequisites:

There is a bit of an overlap, I agree.

I'm fine updating the existing prerequisites with the two bullets we're adding in the Notes, if that helps keep things consistent enough.

@snarayan-redhat
Copy link
Contributor

Closing this PR since following up in PR #96060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants