Skip to content

OSDOCS-12711: Documented the balance-slb mode for networking docs #92313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

OSDOCS-12711: Documented the balance-slb mode for networking docs #92313

merged 1 commit into from
Jun 12, 2025

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 17, 2025 •
edited
Loading

Additional updates made to change the file name pointer. See https://issues.redhat.com//browse/HCIDOCS-699 for the source of the original change. ipi-install-post-installation-configuration.adoc > bare-metal-postinstallation-configuration.adoc

Version(s):
4.19

Issue:
OSDOCS-12711 and DIAGRAMS-552

Link to docs preview:
DAY 0

  • SME has approved this change.
  • QE has approved this change.
  • Graphics review.

Add.resources

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12711 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12711 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-12711

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-12711 branch 2 times, most recently from 2783d09 to e3e87a3 Compare April 17, 2025 09:45
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 17, 2025 •
edited
Loading

🤖 Thu Jun 12 10:46:11 - Prow CI generated the docs preview:

https://92313--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/bare-metal-postinstallation-configuration.html
https://92313--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-installation-workflow.html
https://92313--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-bare-metal.html
https://92313--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-bare-metal-network-customizations.html
https://92313--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-restricted-networks-bare-metal.html

@dfitzmau dfitzmau force-pushed the OSDOCS-12711 branch 10 times, most recently from 6a5ea4d to 40b9650 Compare April 17, 2025 14:36
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2025
dfitzmau
dfitzmau commented Apr 17, 2025
View reviewed changes
dfitzmau
dfitzmau commented Apr 17, 2025
View reviewed changes
@dfitzmau dfitzmau force-pushed the OSDOCS-12711 branch 2 times, most recently from fb0969f to e01b8a2 Compare April 17, 2025 15:00
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2025
@dfitzmau dfitzmau force-pushed the OSDOCS-12711 branch 4 times, most recently from 2ae0266 to df48709 Compare April 17, 2025 15:04
@openshift-ci openshift-ci bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2025
rbbratta
rbbratta reviewed Jun 11, 2025
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
cybertron
cybertron reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12711 which is a valid jira issue.

In response to this:

Additional updates made to change the file name pointer. See https://issues.redhat.com//browse/HCIDOCS-699 for the source of the original change. ipi-install-post-installation-configuration.adoc > bare-metal-postinstallation-configuration.adoc

Version(s):
4.19

Issue:
OSDOCS-12711 and DIAGRAMS-552

Link to docs preview:
DAY 0

  • SME has approved this change.
  • QE has approved this change.
  • Graphics review.

Add.resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-12711 branch 2 times, most recently from 92c1b8f to f56bd10 Compare June 12, 2025 09:40
gabriel-rh
gabriel-rh approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Good writing on a very technical topic! and well done on fixing the problems you inherited from the previous PR

The image is missing in this build - just ensure it is sorted before merge.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@gabriel-rh gabriel-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 12, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 12, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 12, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhradilek
Copy link
Contributor

The diagram looks good to me, thank you for working on it!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12711 which is a valid jira issue.

In response to this:

Additional updates made to change the file name pointer. See https://issues.redhat.com//browse/HCIDOCS-699 for the source of the original change. ipi-install-post-installation-configuration.adoc > bare-metal-postinstallation-configuration.adoc

Version(s):
4.19

Issue:
OSDOCS-12711 and DIAGRAMS-552

Link to docs preview:
DAY 0

  • SME has approved this change.
  • QE has approved this change.
  • Graphics review.

Add.resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau merged commit 9cc275f into openshift:main Jun 12, 2025
2 checks passed
@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #94677

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 12, 2025
Merged
@dfitzmau dfitzmau mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron left review comments

@rbbratta rbbratta rbbratta left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@trozet trozet trozet requested changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

Assignees

@cybertron cybertron

@gabriel-rh gabriel-rh

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.