-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Incorrect command provided for adding SCC to a serviceaccount while deploying KMM in custom namespace. #90077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In below documentation: https://docs.openshift.com/container-platform/4.18/hardware_enablement/kmm-kernel-module-management.html the command provided for adding SCC to a serviceaccount while deploying KMM in custom namespace is incorrect. $ oc adm policy add-scc-to-user privileged -z "${serviceAccountName}" [ -n "${namespace}" ] Above command is giving an error because of incorrect brackets, ideally it should be: Right Command: "$ oc adm policy add-scc-to-user privileged -z serviceAccountName -n namespace" We can add note below the right command: Replace the 'namespace' argument with the 'operator namespace'.
/label peer-review-needed |
Hi @smiglani-r. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why prow didn't give a preview, I removed the needs-ok-to-test label because I thought that might fix. But everything looks good to me pending a preview link and approval from qe.
I think it might have something to do with the merge freeze today. Disregard. |
/retest |
🤖 Thu Apr 10 14:33:15 - Prow CI generated the docs preview: |
@smiglani-r: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
In below documentation:
https://docs.openshift.com/container-platform/4.18/hardware_enablement/kmm-kernel-module-management.html the command provided for adding SCC to a serviceaccount while deploying KMM in custom namespace is incorrect.
$ oc adm policy add-scc-to-user privileged -z "${serviceAccountName}" [ -n "${namespace}" ]
Above command is giving an error because of incorrect brackets, ideally it should be:
Right Command:
"$ oc adm policy add-scc-to-user privileged -z serviceAccountName -n namespace" We can add note below the right command: Replace the 'namespace' argument with the 'operator namespace'.
Version(s):
OCP 4.18
Issue:
https://issues.redhat.com/browse/OCPBUGS-52586
Link to docs preview:
QE review:
Additional information: