OCPBUGS-56664: Support data disks on ASH

[mdbooth]

Proposed replacement for #149. Thanks to @gcampbell12 for that PR.

With #155, the Stack Hub and non-Stack Hub code paths are now mostly common in the virtualmachine service. This PR takes advantage of that to use the common code.

This PR introduces some potentially incompatible behaviour changes when specifying data disk features on a StackHub deployment:

Previously, specifying data disks on a StackHub deployment was silently ignored. With this change they will be created.

Additionally, if we were previously specifying a data disk with features not currently supported on Stack Hub, for example Disk Encryption Set, the machine would be successfully created without any data disks. With this change the machine will enter an error state and not be created.

As these behaviour changes only relate to configurations which were previously invalid, we may decide that this is acceptable.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shellyyang1989]

Closes OCPBUGS-56664

[mdbooth]

Looking through kubernetes-sigs/cluster-api-provider-azure#5532 I notice that there's a separate Disk API version, which is currently being set to 2018-06-01 in that PR with the comment:

// API Version Profile "2020-06-01" is not supported for disks.

Won't be at all surprised to discover that we hit this limitation in this PR, and we'll need to do the same.

[openshift-ci]

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn	e01eea8	link	false	/test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-56664, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Proposed replacement for #149. Thanks to @gcampbell12 for that PR.

With #155, the Stack Hub and non-Stack Hub code paths are now mostly common in the virtualmachine service. This PR takes advantage of that to use the common code.

This PR introduces some potentially incompatible behaviour changes when specifying data disk features on a StackHub deployment:

Previously, specifying data disks on a StackHub deployment was silently ignored. With this change they will be created.

Additionally, if we were previously specifying a data disk with features not currently supported on Stack Hub, for example Disk Encryption Set, the machine would be successfully created without any data disks. With this change the machine will enter an error state and not be created.

As these behaviour changes only relate to configurations which were previously invalid, we may decide that this is acceptable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mdbooth]

/jira refresh

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-56664, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.