WIP: only update the status if there is a change in the deployment #815
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
rphillips
force-pushed
the
fix_updates
branch
from
fb0c623 to
f18dcaa
Compare
rphillips
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
rphillips
force-pushed
the
fix_updates
branch
from
f18dcaa to
eb1d9b4
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@rphillips: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // CRD informer | ||
| crdInformer.Apiextensions().V1().CustomResourceDefinitions().Informer(), | ||
| // for the deployment and its configmap, secret, daemonsets. | ||
| kubeInformersForNamespaces.InformersFor(c.operatorNamespace).Admissionregistration().V1().MutatingWebhookConfigurations().Informer(), |
There was a problem hiding this comment.
Why would we have informers for the operator namespace for validating or mutating webhooks?
I thought they were cluster wide.
There was a problem hiding this comment.
One is supposed to have informers for all the objects being created by the operator to use as an eventer. We might be able to remove the cluster wide ones though.
3 participants
The reconcile loop was triggering every 10s or so. This fix only updates the status when the deployment changes.