Skip to content

CORS-3959, CORS-3864: CAPI AzureStack Support, Take II #9666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

CORS-3959, CORS-3864: CAPI AzureStack Support, Take II #9666

merged 2 commits into from
Apr 17, 2025

Conversation

patrickdillon
Copy link
Contributor

#9645 accidentally broke baremetal installs and was reverted in #9655, per TRT policy. Accordingly, this PR reverts the revert and introduces the fix for baremetal IPI 25aebd2

@patrickdillon
Revert "Merge pull request openshift#9665 from patrickdillon/revert-a…
6e834b3 
…zurestack-ipi"

This reverts commit 2d3f2c5, reversing
changes made to 63e0c35.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@patrickdillon: This pull request references CORS-3959 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references CORS-3864 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

#9645 accidentally broke baremetal installs and was reverted in #9655, per TRT policy. Accordingly, this PR reverts the revert and introduces the fix for baremetal IPI 25aebd2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie and tthvo April 16, 2025 14:27
@patrickdillon
Copy link
Contributor Author

/payload-job metal-ipi-ovn-bm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

@patrickdillon: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@patrickdillon
handle baremetal platform in CAPI manifests
4ac6ef7 
Baremetal IPI does not use any CAPI manifests so, handle the platform.
@patrickdillon patrickdillon force-pushed the revert-capzash-revert branch from 25aebd2 to 4ac6ef7 Compare April 16, 2025 14:46
@tthvo
Copy link
Member

tthvo commented Apr 16, 2025

/retest

@patrickdillon
Copy link
Contributor Author

/payload-job metal-ipi-ovn-bm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

@patrickdillon: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@patrickdillon patrickdillon reopened this Apr 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@patrickdillon: This pull request references CORS-3959 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references CORS-3864 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

#9645 accidentally broke baremetal installs and was reverted in #9655, per TRT policy. Accordingly, this PR reverts the revert and introduces the fix for baremetal IPI 25aebd2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor Author

Geez this PR number even has the mark of the beast!

@patrickdillon
Copy link
Contributor Author

/skip
/retest-required

@patrickdillon patrickdillon mentioned this pull request Apr 16, 2025
Merged
tthvo
tthvo reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geez this PR number even has the mark of the beast!

Unfortunate 🫠

/jira refresh
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@patrickdillon
Copy link
Contributor Author

Ooh tests are back

let's test some metal

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

@patrickdillon: The following commands are available to trigger required jobs:

/test altinfra-images

/test aro-unit

/test artifacts-images

/test artifacts-okd-scos-images

/test e2e-agent-compact-ipv4

/test e2e-aws-ovn

/test e2e-aws-ovn-edge-zones-manifest-validation

/test e2e-aws-ovn-upi

/test e2e-azure-ovn

/test e2e-gcp-ovn

/test e2e-gcp-ovn-upi

/test e2e-metal-ipi-ovn-ipv6

/test e2e-openstack-ovn

/test e2e-vsphere-ovn

/test e2e-vsphere-ovn-upi

/test gofmt

/test golint

/test govet

/test images

/test integration-tests

/test integration-tests-nodejoiner

/test okd-scos-images

/test openstack-manifests

/test terraform-images

/test terraform-okd-scos-images

/test terraform-okd-scos-verify-vendor

/test terraform-verify-vendor

/test unit

/test verify-codegen

/test verify-vendor

The following commands are available to trigger optional jobs:

/test altinfra-e2e-aws-custom-security-groups

/test altinfra-e2e-aws-ovn

/test altinfra-e2e-aws-ovn-fips

/test altinfra-e2e-aws-ovn-imdsv2

/test altinfra-e2e-aws-ovn-localzones

/test altinfra-e2e-aws-ovn-proxy

/test altinfra-e2e-aws-ovn-shared-vpc

/test altinfra-e2e-aws-ovn-shared-vpc-local-zones

/test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones

/test altinfra-e2e-aws-ovn-single-node

/test altinfra-e2e-aws-ovn-wavelengthzones

/test altinfra-e2e-azure-capi-ovn

/test altinfra-e2e-azure-ovn-shared-vpc

/test altinfra-e2e-gcp-capi-ovn

/test altinfra-e2e-gcp-ovn-byo-network-capi

/test altinfra-e2e-gcp-ovn-secureboot-capi

/test altinfra-e2e-gcp-ovn-xpn-capi

/test altinfra-e2e-ibmcloud-capi-ovn

/test altinfra-e2e-nutanix-capi-ovn

/test altinfra-e2e-openstack-capi-ccpmso

/test altinfra-e2e-openstack-capi-ccpmso-zone

/test altinfra-e2e-openstack-capi-dualstack

/test altinfra-e2e-openstack-capi-dualstack-upi

/test altinfra-e2e-openstack-capi-dualstack-v6primary

/test altinfra-e2e-openstack-capi-externallb

/test altinfra-e2e-openstack-capi-nfv-intel

/test altinfra-e2e-openstack-capi-ovn

/test altinfra-e2e-openstack-capi-proxy

/test altinfra-e2e-vsphere-capi-multi-vcenter-ovn

/test altinfra-e2e-vsphere-capi-ovn

/test altinfra-e2e-vsphere-capi-static-ovn

/test altinfra-e2e-vsphere-capi-zones

/test azure-ovn-marketplace-images

/test e2e-agent-4control-ipv4

/test e2e-agent-5control-ipv4

/test e2e-agent-compact-ipv4-appliance-diskimage

/test e2e-agent-compact-ipv4-none-platform

/test e2e-agent-compact-ipv6-minimaliso

/test e2e-agent-ha-dualstack

/test e2e-agent-sno-ipv4-pxe

/test e2e-agent-sno-ipv6

/test e2e-aws-default-config

/test e2e-aws-overlay-mtu-ovn-1200

/test e2e-aws-ovn-custom-iam-profile

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-heterogeneous

/test e2e-aws-ovn-imdsv2

/test e2e-aws-ovn-proxy

/test e2e-aws-ovn-public-ipv4-pool

/test e2e-aws-ovn-public-ipv4-pool-disabled

/test e2e-aws-ovn-public-subnets

/test e2e-aws-ovn-shared-vpc-custom-security-groups

/test e2e-aws-ovn-shared-vpc-edge-zones

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-techpreview

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-user-provisioned-dns

/test e2e-aws-upi-proxy

/test e2e-azure-default-config

/test e2e-azure-ovn-resourcegroup

/test e2e-azure-ovn-shared-vpc

/test e2e-azure-ovn-techpreview

/test e2e-azure-ovn-upi

/test e2e-azurestack

/test e2e-azurestack-upi

/test e2e-crc

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-gcp-default-config

/test e2e-gcp-ovn-byo-vpc

/test e2e-gcp-ovn-heterogeneous

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-xpn

/test e2e-gcp-secureboot

/test e2e-gcp-upgrade

/test e2e-gcp-upi-xpn

/test e2e-gcp-user-provisioned-dns

/test e2e-ibmcloud-ovn

/test e2e-metal-assisted

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-swapped-hosts

/test e2e-metal-ipi-ovn-virtualmedia

/test e2e-metal-ovn-two-node-arbiter

/test e2e-metal-single-node-live-iso

/test e2e-nutanix-ovn

/test e2e-openstack-ccpmso

/test e2e-openstack-ccpmso-zone

/test e2e-openstack-dualstack

/test e2e-openstack-dualstack-upi

/test e2e-openstack-externallb

/test e2e-openstack-nfv-intel

/test e2e-openstack-proxy

/test e2e-openstack-singlestackv6

/test e2e-powervs-capi-ovn

/test e2e-vsphere-externallb-ovn

/test e2e-vsphere-host-groups-ovn-custom-no-upgrade

/test e2e-vsphere-multi-vcenter-ovn

/test e2e-vsphere-ovn-multi-disk

/test e2e-vsphere-ovn-multi-network

/test e2e-vsphere-ovn-multi-network-techpreview

/test e2e-vsphere-ovn-techpreview

/test e2e-vsphere-ovn-upi-zones

/test e2e-vsphere-ovn-zones

/test e2e-vsphere-ovn-zones-techpreview

/test e2e-vsphere-static-ovn

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-installer-main-altinfra-images

pull-ci-openshift-installer-main-aro-unit

pull-ci-openshift-installer-main-artifacts-images

pull-ci-openshift-installer-main-artifacts-okd-scos-images

pull-ci-openshift-installer-main-azure-ovn-marketplace-images

pull-ci-openshift-installer-main-e2e-aws-ovn

pull-ci-openshift-installer-main-e2e-azure-default-config

pull-ci-openshift-installer-main-e2e-azure-ovn

pull-ci-openshift-installer-main-e2e-azure-ovn-resourcegroup

pull-ci-openshift-installer-main-e2e-azure-ovn-shared-vpc

pull-ci-openshift-installer-main-e2e-azurestack

pull-ci-openshift-installer-main-e2e-gcp-default-config

pull-ci-openshift-installer-main-e2e-gcp-ovn

pull-ci-openshift-installer-main-e2e-gcp-ovn-byo-vpc

pull-ci-openshift-installer-main-e2e-gcp-ovn-xpn

pull-ci-openshift-installer-main-e2e-gcp-secureboot

pull-ci-openshift-installer-main-e2e-vsphere-externallb-ovn

pull-ci-openshift-installer-main-e2e-vsphere-ovn-multi-network

pull-ci-openshift-installer-main-e2e-vsphere-static-ovn

pull-ci-openshift-installer-main-gofmt

pull-ci-openshift-installer-main-golint

pull-ci-openshift-installer-main-govet

pull-ci-openshift-installer-main-images

pull-ci-openshift-installer-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-installer-main-okd-scos-images

pull-ci-openshift-installer-main-terraform-images

pull-ci-openshift-installer-main-terraform-okd-scos-images

pull-ci-openshift-installer-main-unit

pull-ci-openshift-installer-main-verify-codegen

pull-ci-openshift-installer-main-verify-vendor

In response to this:

Ooh tests are back

let's test some metal

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@patrickdillon
Copy link
Contributor Author

/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-ipv6

@tthvo
Copy link
Member

tthvo commented Apr 17, 2025

Looks like metal jobs are passing 😃 and ci/prow/e2e-azurestack seems to reach where it should be, woohoo!

Tho e2e-aws-ovn has been timing out at destroy everywhere 🫠

/test e2e-aws-ovn

@patrickdillon
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@patrickdillon
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn

This is a known failure coming from rate throttling in destroy code

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

This is a known failure coming from rate throttling in destroy code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025 •
edited
Loading

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-multi-network 4ac6ef7 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-azurestack 4ac6ef7 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

/skip
/retest-required

@patrickdillon
Copy link
Contributor Author

/override ci/prow/e2e-azure-ovn

This has already passed install on this run and passed e2e on this same commit previously. I don't want to risk further retest hell and holding up additional prs.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-azure-ovn

In response to this:

/override ci/prow/e2e-azure-ovn

This has already passed install on this run and passed e2e on this same commit previously. I don't want to risk further retest hell and holding up additional prs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 8af70ee into openshift:main Apr 17, 2025
33 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202504180114.p0.g8af70ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202504180114.p0.g8af70ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202504180114.p0.g8af70ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202504180114.p0.g8af70ee.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@bfournie bfournie Awaiting requested review from bfournie

Assignees

@tthvo tthvo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickdillon @openshift-ci-robot @tthvo @openshift-bot