Skip to content

[WIP] SPLAT-2297: Added new cmd flag to launch of vSphere CCM #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vr4manta
Copy link

@vr4manta vr4manta commented Jul 2, 2025

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2025

@vr4manta: This pull request references SPLAT-2297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2025
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2025

@vr4manta: This pull request references SPLAT-2297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants