Skip to content

OCPBUGS-56508: Fix config-sync-controller logging #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

OCPBUGS-56508: Fix config-sync-controller logging #389

merged 1 commit into from
May 28, 2025

Conversation

jcpowermac
Copy link
Contributor

  • Switched klog textlogger to just plain klog

Other controller fixed here:
913d6d9

@jcpowermac
Fix config-sync-controller logging
de9dd4d 
- Switched klog textlogger to just plain klog
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2025
@openshift-ci-robot
Copy link

@jcpowermac: This pull request references Jira Issue OCPBUGS-56508, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Switched klog textlogger to just plain klog

Other controller fixed here:
913d6d9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from elmiko and sub-mod May 20, 2025 14:21
@jcpowermac
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2025
@openshift-ci-robot
Copy link

@jcpowermac: This pull request references Jira Issue OCPBUGS-56508, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 May 20, 2025 14:22
@jcpowermac
Copy link
Contributor Author

/assign @theobarberbany

@jcpowermac
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@jcpowermac: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vr4manta
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn de9dd4d link false /test okd-scos-e2e-aws-ovn
ci/prow/level0-clusterinfra-azure-ipi-proxy-tests de9dd4d link false /test level0-clusterinfra-azure-ipi-proxy-tests
ci/prow/e2e-gcp-ovn-upgrade de9dd4d link false /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

theobarberbany
theobarberbany reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@theobarberbany theobarberbany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3486b5c into openshift:main May 28, 2025
16 of 19 checks passed
@openshift-ci-robot
Copy link

@jcpowermac: Jira Issue OCPBUGS-56508: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56508 has been moved to the MODIFIED state.

In response to this:

  • Switched klog textlogger to just plain klog

Other controller fixed here:
913d6d9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@jcpowermac: new pull request created: #390

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2025
Open
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-cloud-controller-manager-operator
This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.20.0-202505281454.p0.g3486b5c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theobarberbany theobarberbany theobarberbany left review comments

@elmiko elmiko Awaiting requested review from elmiko

@sub-mod sub-mod Awaiting requested review from sub-mod

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

Assignees

@theobarberbany theobarberbany

@vr4manta vr4manta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcpowermac @openshift-ci-robot @openshift-cherrypick-robot @vr4manta @openshift-bot @theobarberbany