Skip to content

Avoid e2e to pass with faulty status #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Apr 29, 2025

Improves the verifyOperatorStatusCondition function to not allow bypassing status.Conditions when empty or has the required condition type(s) missing.

In #263, we managed to get the e2e pass with a faulty status update client that always kept the conditions array empty in the certmanager.operator/cluster resource.

when empty or has the required condition type missing

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and TrilokGeer April 29, 2025 07:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@swghosh
Copy link
Member Author

swghosh commented Apr 29, 2025

/assign @lunarwhite
/cc @siddhibhor-56

@lunarwhite
Copy link
Member

/test e2e-operator

@swghosh
Copy link
Member Author

swghosh commented Apr 29, 2025

/label px-approved
/label docs-approved
Self-adding, no user facing changes.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 29, 2025
@swghosh
Copy link
Member Author

swghosh commented Apr 29, 2025

/hold
Need to update the condition count, and also verify Status.Generations is rightly populated.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2025
@swghosh
Copy link
Member Author

swghosh commented Apr 30, 2025

/remove-hold

we need the e2e with these changes to run successfully on #263,
helps us verify that .Status (with both .conditions and .generations) is/are updated correctly.

For context, we ran into an issue where server-side-apply (SSA) over .status.generations for the certmanager.operator object was broken in the CRD: https://redhat-internal.slack.com/archives/CE4L0F143/p1745930519786209.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2025
@swghosh swghosh changed the title Avoid e2e to pass with faulty status conditions Avoid e2e to pass with faulty status Apr 30, 2025
with all cert-manager deployments

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label qe-approved

Thanks for your work!

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Apr 30, 2025
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lunarwhite, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 81a60fb into openshift:master Apr 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants