-
Notifications
You must be signed in to change notification settings - Fork 34
Avoid e2e to pass with faulty status #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
when empty or has the required condition type missing Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
/assign @lunarwhite |
/test e2e-operator |
/label px-approved |
/hold |
/remove-hold we need the e2e with these changes to run successfully on #263, For context, we ran into an issue where server-side-apply (SSA) over |
with all cert-manager deployments Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label qe-approved
Thanks for your work!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lunarwhite, swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Improves the
verifyOperatorStatusCondition
function to not allow bypassingstatus.Conditions
when empty or has the required condition type(s) missing.In #263, we managed to get the e2e pass with a faulty status update client that always kept the conditions array empty in the certmanager.operator/cluster resource.