ci: migrate golangci to v2 schema and correct issues

[sebrandon1]

Similar to other v2 migrations:

• golangci-lint: migration to v2 redhat-best-practices-for-k8s/certsuite#2875

There were a number of things that the latest version of golangci-lint flagged for fixing.

Also, I added a .github/workflows/pre-main.yaml that contains a job to run the linter prior to merging PRs.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sebrandon1]

It seems like Actions aren't enabled on this repository. Is that something that can be enabled by an admin?

[sebrandon1]

/ok-to-test

[swghosh]

Like the idea of linting our codebase,
but we cannot use GitHub actions immediately.

[swghosh]

We could add a make target in this repository that runs the linter with the proposed .golangci.yaml config.

[swghosh]

And, add a new linter test onto our CI configs, feel free to raise PRs on o/release for this.

That way we do not need to introduce extraneous GitHub Actions (and end up paying for runners).

[sebrandon1]

This PR uses ubuntu-latest runners which are the free tier, no billing plan required.

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

As for the make target, I agree we could also add that. The action golangci/golangci-lint-action@v7 automatically detects the .golangci.yml and uses those settings and manages the installation and running of the linter for us.

[openshift-ci]

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	423bb1e	link	true	/test e2e-operator
ci/prow/e2e-operator-tech-preview	423bb1e	link	false	/test e2e-operator-tech-preview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.