-
Notifications
You must be signed in to change notification settings - Fork 36
context consistency: ensure all context are TODO() #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @sebrandon1. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
969e017
to
eee7773
Compare
/ok-to-test |
eee7773
to
f4dfb9c
Compare
f4dfb9c
to
31307d1
Compare
/retest |
1 similar comment
/retest |
31307d1
to
ff341f3
Compare
/test all |
Hi @sebrandon1, you may need to rebase onto the latesr commit. There have been some changes in |
ff341f3
to
ef1d2e1
Compare
ef1d2e1
to
4ed1587
Compare
@sebrandon1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be safely removed. Then the broken CI jobs should pass.
(for your context: This file has been removed in a recent refactor PR)
There were
14
instances ofcontext.Background
and20
instances ofcontext.TODO()
. Since there were moreTODO()
references, I'm ensuring all of the references to context are the same.Similar to: