-
Notifications
You must be signed in to change notification settings - Fork 88
SREP-144: Switch to UBI9 and install Go 1.24 #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/hold |
8603b3a
to
69453af
Compare
@@ -42,20 +51,13 @@ RUN go install sigs.k8s.io/kustomize/kustomize/v5@${KUSTOMIZE_VERSION} && \ | |||
# which is what consumes this image in CI. | |||
# Here we make group permissions match user permissions, since the CI | |||
# non-root user's gid is 0. | |||
SHELL ["/bin/bash", "-c"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecated directive
ENV GOFLAGS="-mod=mod" | ||
FROM registry.redhat.io/ubi9:9.6-1751445649 | ||
|
||
RUN dnf -y install openssh-clients jq skopeo python3-pyyaml git go-toolset rsync && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from later in the file, added git, go-toolset, rsync
@joshbranham: This pull request references SREP-144 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
I built
And the resulting diff to build this diff --git a/build/Dockerfile b/build/Dockerfile
index b241f670..b682e48b 100644
--- a/build/Dockerfile
+++ b/build/Dockerfile
@@ -1,4 +1,4 @@
-FROM quay.io/redhat-services-prod/openshift/boilerplate:image-v7.4.0 AS builder
+FROM localhost/boilerplate:latest AS builder
ENV OPERATOR_PATH=/go/src/github.com/openshift/aws-account-operator
ENV GO111MODULE=on
@@ -10,7 +10,7 @@ WORKDIR ${OPERATOR_PATH}
RUN make go-build FIPS_ENABLED=${FIPS_ENABLED}
-FROM registry.access.redhat.com/ubi8/ubi-minimal:8.10-1752564239
+FROM registry.access.redhat.com/ubi9/ubi-minimal:9.6-1752587672
ENV OPERATOR_BIN=aws-account-operator
WORKDIR /root/ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dakotalongRH, joshbranham The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
This PR bumps UBI8 to UBI9 for our base image template, the OLM registry image, and Boilerplate's own image used in CI and to build operators from. Additionally, this bumps Go to 1.24.
In order to make this work, we need to switch to a base UBI image and install
go-toolset
ourselves. The primary reason for this is there is no golang builder image with ubi9. The next bump ofbrew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_8_1.23
is built with rhel9 and thereforednf install
ing packages becomes a bit more annoying locally.By switching to a plain UBI9 base image, we can control all the packages we need and utilize the UBI repos locally and in CI.
Once this merges, we will need to cut a new image for Boilerplate, and direct consumers on how to migrate.