-
Notifications
You must be signed in to change notification settings - Fork 324
TLS support for auxiliary transports #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
finnegancarroll
wants to merge
67
commits into
opensearch-project:main
Choose a base branch
from
finnegancarroll:dynamic-aux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TLS support for auxiliary transports #5375
finnegancarroll
wants to merge
67
commits into
opensearch-project:main
from
finnegancarroll:dynamic-aux
+1,660
−498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
6 tasks
5 tasks
3f03af7
to
f8cca8d
Compare
62fd182
to
1bbb420
Compare
1bbb420
to
9614f9e
Compare
Merged
3 tasks
7604e9c
to
9207ee9
Compare
d59bbf1
to
d0ec7b4
Compare
910aea9
to
f3f6c97
Compare
@cwperks can you take a look when convenient? |
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
…flaky tests. Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
…ert types. Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
0297368
to
9d1e301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In core auxiliary transports may implement secure variants . Secure aux transports expect to consume a SecureAuxTransportSettingsProvider as provided by the security plugin.
SecureAuxTransportSettingsProvider
delivers anSSLContext
to the transport, enabling TLS on client/server connections.Currently the is no way to configure TLS for an auxiliary transport in the security plugin and the provided
SecureAuxTransportSettingsProvider
is always empty. This PR introduces settings which allow users to configure each aux transport to provide a validSecureAuxTransportSettingsProvider
.Configuration settings for each aux transport exist under distinct namespaces, where the identifier for the transport is the same as the key for enabling it under setting
aux.transport.types
.Note that these changes provide no authorization component and only work to deliver an SSL configuration. Users can configure
clientauth_mode
to allow/disallow certificates access to a particular transport, but no permissions are enforced and no user is associated with a successfully authenticated client.Testing
These changes add mock aux transports to unit tests for
SslContextHandler
.However security plugin is agnostic as to the existence of other plugins available to OpenSearch.
Since auxiliary transports are implemented as plugins validating these changes was done manually by installing security plugin and the secure gRPC transport on a single node cluster.
Env variables for convenience:
Build OpenSearch/security plugin/gRPC plugin:
Install both plugins:
Create demo certs for security plugin - Respond yes yes no (keeping cluster mode disabled):
Enable the secure gRPC auxiliary transport:
Configure security settings with demo certs (.pem format):
Note: This example configures
clientauth_mode: REQUIRE
.Start OpenSearch:
Test plaintext connection:
Test insecure TLS with no client certificate provided:
Test TLS with client certificate provided:
Note:
-insecure
to skip host name verification.Issues Resolved
#17795
Testing
Unit tests and integration tests for mock auxiliary transport CertTypes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.