Add setting for number of documents stored by HybridCollapsingTopDocsCollector #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…Collector Signed-off-by: Ryan Bogan <rbogan@amazon.com>
|
Open to feedback on default value and upper limit for the new setting |
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
ryanbogan
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws,
minalsha and
bzhangam
as code owners
|
|
||
| public static final Setting<Integer> HYBRID_COLLAPSE_DOCS_PER_GROUP = Setting.intSetting( | ||
| "index.neural_search.hybrid_collapse_docs_per_group", | ||
| 10, |
There was a problem hiding this comment.
I believe that is default value for this setting, is this based on some experimental data? does it give good balance between accuracy and performance?
There was a problem hiding this comment.
I'm changing this to default to the current behavior, which is using the size of the query.
| @@ -47,4 +47,13 @@ public final class NeuralSearchSettings { | |||
| Setting.Property.IndexScope, | |||
| Setting.Property.Dynamic | |||
| ); | |||
|
|
|||
| public static final Setting<Integer> HYBRID_COLLAPSE_DOCS_PER_GROUP = Setting.intSetting( | |||
| "index.neural_search.hybrid_collapse_docs_per_group", | |||
There was a problem hiding this comment.
This setting name is lacking visibility that it's per sub-query. Can we add that context, maybe something like hybrid_collapse_docs_per_group_per_subquery or a bit less informative hybrid_collapse_max_docs_per_group
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
martin-gaievski
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a setting that allows users to control the number of documents that are stored in each queue within HybridCollapsingTopDocsCollector. Lowering this setting prioritizes latency over recall, while raising the setting does the opposite.
Related Issues
Resolves #1381
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.