-
Notifications
You must be signed in to change notification settings - Fork 95
Support multi node integ tests #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi node integ tests #1320
Conversation
c4578a3
to
e4cb9cf
Compare
Gradle check is failing. |
@owaiskazi19 Can you update the change log? |
Unrelated test is failing on main as well
|
0fd5b66
to
0b70dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the PR @owaiskazi19 !
Not have much context on the current flakey tests. Can @vibrantvarun help verify? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! @owaiskazi19
884db8a
to
cd66471
Compare
@yuye-aws fixed the codecov issues and improved the CI. This should be good to review. |
7c0357f
to
0f0297d
Compare
Signed-off-by: Owais <owaiskazi19@gmail.com>
0f0297d
to
cf01da8
Compare
need to load and wait for model before running the test similar to bwc tests |
Signed-off-by: Owais <owaiskazi19@gmail.com>
9576116
to
c165d1c
Compare
Signed-off-by: Owais <owaiskazi19@gmail.com>
src/testFixtures/java/org/opensearch/neuralsearch/BaseNeuralSearchIT.java
Outdated
Show resolved
Hide resolved
src/testFixtures/java/org/opensearch/neuralsearch/BaseNeuralSearchIT.java
Outdated
Show resolved
Hide resolved
src/testFixtures/java/org/opensearch/neuralsearch/BaseNeuralSearchIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais <owaiskazi19@gmail.com>
Signed-off-by: Owais <owaiskazi19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Description
Support multi node integ tests.
Improvements done for CI in this PR:
Related Issues
Resolves ##1307
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.