Skip to content

Support multi node integ tests #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 29, 2025

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented May 12, 2025

Description

Support multi node integ tests.
Improvements done for CI in this PR:

  1. example 1, example 2 integ test was running twice in precommit and check. Removed running integTest again in precommit
  2. jacocotestReport tasks depends on test and integTest. Since gradle check already runs both, moved codeCov CI under gradle check.
  3. Added multi node integration tests CI

Related Issues

Resolves ##1307

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 force-pushed the multi-node-tests branch 3 times, most recently from c4578a3 to e4cb9cf Compare May 13, 2025 08:44
@owaiskazi19 owaiskazi19 marked this pull request as ready for review May 13, 2025 18:05
@owaiskazi19 owaiskazi19 changed the title [DRAFT] Support multi node integ tests Support multi node integ tests May 13, 2025
@vibrantvarun
Copy link
Member

Gradle check is failing.

@yuye-aws
Copy link
Member

@owaiskazi19 Can you update the change log?

@owaiskazi19
Copy link
Member Author

Unrelated test is failing on main as well

REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.neuralsearch.search.query.HybridCollectorManagerTests.testRescoreWithConcurrentSegmentSearch_whenMatchedDocsAndRescore_thenSuccessful" -Dtests.seed=31B75FEED86AF287 -Dtests.security.manager=false -Dtests.locale=fi-FI -Dtests.timezone=Europe/Brussels -Druntime.java=23

HybridCollectorManagerTests > testRescoreWithConcurrentSegmentSearch_whenMatchedDocsAndRescore_thenSuccessful FAILED
    java.lang.AssertionError: expected:<3> but was:<1>
        at __randomizedtesting.SeedInfo.seed([31B75FEED86AF287:BB4DF1B8A1D4DC19]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at org.opensearch.neuralsearch.search.query.HybridCollectorManagerTests.testRescoreWithConcurrentSegmentSearch_whenMatchedDocsAndRescore_thenSuccessful(HybridCollectorManagerTests.java:1019)

@owaiskazi19 owaiskazi19 requested a review from yuye-aws May 20, 2025 05:26
Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR @owaiskazi19 !

@yuye-aws
Copy link
Member

Not have much context on the current flakey tests. Can @vibrantvarun help verify?

Copy link
Member

@junqiu-lei junqiu-lei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! @owaiskazi19

@owaiskazi19 owaiskazi19 force-pushed the multi-node-tests branch 8 times, most recently from 884db8a to cd66471 Compare July 24, 2025 07:49
@owaiskazi19
Copy link
Member Author

@yuye-aws fixed the codecov issues and improved the CI. This should be good to review.

@owaiskazi19 owaiskazi19 force-pushed the multi-node-tests branch 4 times, most recently from 7c0357f to 0f0297d Compare July 24, 2025 08:20
Signed-off-by: Owais <owaiskazi19@gmail.com>
@owaiskazi19
Copy link
Member Author

REPRODUCE WITH: ./gradlew ':integTest' --tests 'org.opensearch.neuralsearch.processor.semantic.SemanticFieldProcessorIT.testSemanticFieldProcessor_withSparseModel' -Dtests.seed=BCD1D0E51A2AA11A -Dtests.security.manager=false -Dtests.locale=so -Dtests.timezone=America/Cayman -Druntime.java=23

SemanticFieldProcessorIT > testSemanticFieldProcessor_withSparseModel FAILED
    java.lang.AssertionError: failed to load the model, last task finished with status RUNNING
        at __randomizedtesting.SeedInfo.seed([BCD1D0E51A2AA11A:61A81B9B0F54104B]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.opensearch.neuralsearch.BaseNeuralSearchIT.loadModel(BaseNeuralSearchIT.java:297)
        at org.opensearch.neuralsearch.processor.semantic.SemanticFieldProcessorIT.testSemanticFieldProcessor_withSparseModel(SemanticFieldProcessorIT.java:51)

need to load and wait for model before running the test similar to bwc tests

@owaiskazi19 owaiskazi19 reopened this Jul 25, 2025
Signed-off-by: Owais <owaiskazi19@gmail.com>
Signed-off-by: Owais <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 reopened this Jul 25, 2025
Signed-off-by: Owais <owaiskazi19@gmail.com>
Signed-off-by: Owais <owaiskazi19@gmail.com>
Copy link
Collaborator

@heemin32 heemin32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@martin-gaievski martin-gaievski merged commit 901307f into opensearch-project:main Jul 29, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants