[FEATURE] Support MCP for Flow and Conversational Flow Agent #4318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…search-project#3243) * Use _list/indices API instead of _cat/index API in CatIndexTool Signed-off-by: zane-neo <zaniu@amazon.com> * change assert to avoid flaky in test Signed-off-by: zane-neo <zaniu@amazon.com> * add example of responsestr and change default size to 100 Signed-off-by: zane-neo <zaniu@amazon.com> * add ListIndexTool and revert CatIndexTool change Signed-off-by: zane-neo <zaniu@amazon.com> * Use random string instead of number sequence Signed-off-by: zane-neo <zaniu@amazon.com> * fix failure IT Signed-off-by: zane-neo <zaniu@amazon.com> * change comment to _list/indices API rest action file Signed-off-by: zane-neo <zaniu@amazon.com> * add page size parameter from input and change sef4j to log4j Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * Add UT for ListIndexTool Signed-off-by: zane-neo <zaniu@amazon.com> * rebase main Signed-off-by: zane-neo <zaniu@amazon.com> * Fix UT failure Signed-off-by: zane-neo <zaniu@amazon.com> * Change resource name to fix IT failure Signed-off-by: zane-neo <zaniu@amazon.com> * Add more UTs to increase coverage Signed-off-by: zane-neo <zaniu@amazon.com> * Remove CatIndexTool to keep only ListIndexTool Signed-off-by: zane-neo <zaniu@amazon.com> * Remove temp file Signed-off-by: zane-neo <zaniu@amazon.com> * Remove CatIndexTool Signed-off-by: zane-neo <zaniu@amazon.com> * Fix jacoco result not updated to latest commit issue Signed-off-by: zane-neo <zaniu@amazon.com> * Change file path to under plugin module Signed-off-by: zane-neo <zaniu@amazon.com> * fix failure tests Signed-off-by: zane-neo <zaniu@amazon.com> * Remove assert to ensure IT pass Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
* add release note 3.0 alpha1 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add more commits Signed-off-by: Mingshi Liu <mingshl@amazon.com> * move category Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…#3652) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
2.24.2 version of log4j introduces an exception: apache/logging-log4j2#3234, causing falkiness in test cases. Removing this will use the version used in openSearch core (currently 2.21.0 Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…#3658) Signed-off-by: Sicheng Song <sicheng.song@outlook.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
* add standard blueprint for vector search Signed-off-by: Mingshi Liu <mingshl@amazon.com> * remove add trusted endpoint Signed-off-by: Mingshi Liu <mingshl@amazon.com> * use english sentence in predict Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…rch-project#3644) * [FEATURE] Improve test coverage for MLHttpClientFactory.java Improved the test coverage by adding edge cases. The if check (bytes.length != 4) is an unreachable code, Inet4Address always will have array of 4 bytes address. Resolves opensearch-project#1379 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com> * [FEATURE] Improve test coverage for MLHttpClientFactory.java Improved the test coverage by adding edge cases. The if check (bytes.length != 4) is an unreachable code, Inet4Address always will have array of 4 bytes address. Resolves opensearch-project#1379 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com> * [FEATURE] Improve test coverage for MLHttpClientFactory.java Improved the test coverage by adding edge cases. The if check (bytes.length != 4) is an unreachable code, Inet4Address always will have array of 4 bytes address. Resolves opensearch-project#1379 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com> --------- Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…arch-project#3679) Improved the test coverage by adding the edge case. Some of the branch coverages which are mssing are unreachable code. The Function, ConnectorExecutor and Ingester values are non null. Resolves opensearch-project#1377 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…t#3675) Improved the test coverage by adding missed use cases. There is no zero argument constructor, constructor with Input as paremeter and constructor with MLAlgoParams.class as paremeter in the class class org.opensearch.ml.engine.algorithms.metrics_correlation.MetricsCorrelation. So it is impossible to cover remianing potions, it always throws java.lang.NoSuchMethodException: org.opensearch.ml.engine.algorithms.metrics_correlation.MetricsCorrelation.<init>(). Resolves opensearch-project#1376 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
* bump version Signed-off-by: Mingshi Liu <mingshl@amazon.com> * resolve dependency Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Xun Zhang <xunzh@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Aaron (Aron) Roh <roharon98@gmail.com> Signed-off-by: roharon <roharon98@gmail.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…ect#3700) * fix config index masterkey pull up for multi-tenancy Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * apply spotless Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * add more unit test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comment Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comment Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * changing to OpenSearchException Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…pensearch-project#3707) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…rch-project#3876) Replaced the word elasticsearch with OpenSearch Resolves opensearch-project#3875 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
* Add tests for MCP feature Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * Add more UTs Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * cleanup code Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * Add license header, rename helper function Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> --------- Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…earch-project#3852) * fix the tutorial in AIConnectorHelper when fetching domain_url Signed-off-by: Xun Zhang <xunzh@amazon.com> * fix for deepseek notebook Signed-off-by: Xun Zhang <xunzh@amazon.com> --------- Signed-off-by: Xun Zhang <xunzh@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
* for inline model connector name isn't required Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding unit test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * test was failing Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
…arch-project#3778) * feat: adding UTs for plan execute reflect agent Signed-off-by: Pavan Yekbote <pybot@amazon.com> * wip Signed-off-by: Pavan Yekbote <pybot@amazon.com> * feat: add more test cases for per agent Signed-off-by: Pavan Yekbote <pybot@amazon.com> * fix: saveAndReturnFinalResult testcase Signed-off-by: Pavan Yekbote <pybot@amazon.com> * feat: adding test cases for agentutils, connectorutils, transportregisteragent Signed-off-by: Pavan Yekbote <pybot@amazon.com> * chore: remove max steps test post rebase Signed-off-by: Pavan Yekbote <pybot@amazon.com> * chore: add todo for max_steps reached Signed-off-by: Pavan Yekbote <pybot@amazon.com> --------- Signed-off-by: Pavan Yekbote <pybot@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Resolves opensearch-project#3807 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
akolarkunnu
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #3807
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.