[Backport 3.0] Adds Json Parsing to nested object during update Query step in ML Inference Request processor #3867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…erence Request processor (#3856) * adds json parsing to modelOutputValue during query rewrite Signed-off-by: Brian Flores <iflorbri@amazon.com> * add Unit Test for queryTemplate change Signed-off-by: Brian Flores <iflorbri@amazon.com> * refactors and adds new UT Signed-off-by: Brian Flores <iflorbri@amazon.com> * apply spotless Signed-off-by: Brian Flores <iflorbri@amazon.com> * replace tab with spaces on multi-line comment Signed-off-by: Brian Flores <iflorbri@amazon.com> --------- Signed-off-by: Brian Flores <iflorbri@amazon.com> (cherry picked from commit 532284e)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #3867 +/- ##
============================================
+ Coverage 77.94% 77.96% +0.01%
- Complexity 7275 7277 +2
============================================
Files 650 650
Lines 32891 32893 +2
Branches 3693 3694 +1
============================================
+ Hits 25638 25644 +6
+ Misses 5673 5670 -3
+ Partials 1580 1579 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dhrubo-os
approved these changes
May 23, 2025
mingshl
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 532284e from #3856