Fix connector private IP validation when executing agent without remote model #3862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
nathaliellenaa
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
nathaliellenaa
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
nathaliellenaa
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
nathaliellenaa
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
nathaliellenaa
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix private IP validation issue that occurs when executing agent with connector directly (without remote model). Initially, RemoteConnectorExecutor has an empty setConnectorPrivateIpEnabled setter which is normally set through RemoteModel during initialization. However, when agent uses connector directly, this setting remains uninitialized, causing IP validation to fail. This change will ensure proper IP validation when connector is used directly by agents or using it through remote model.
Related Issues
Resolves #3839
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.