-
Notifications
You must be signed in to change notification settings - Fork 158
Prompt Management SEARCH API #3849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/prompt
Are you sure you want to change the base?
Conversation
Signed-off-by: seungwon cho <rycho@amazon.com>
Signed-off-by: seungwon cho <rycho@amazon.com>
Signed-off-by: seungwon cho <rycho@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/prompt #3849 +/- ##
=================================================
Coverage 78.15% 78.16%
- Complexity 7399 7404 +5
=================================================
Files 662 665 +3
Lines 33345 33370 +25
Branches 3738 3737 -1
=================================================
+ Hits 26060 26082 +22
- Misses 5689 5692 +3
Partials 1596 1596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this test file should be one level higher to match code class MLPrompt.java file location
|
||
this.name = name; | ||
this.description = description; | ||
this.version = version; | ||
this.version = version == null ? PROMPT_VERSION_INITIAL_VERSION : version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that version will now be auto initialized to 1 when creating a new prompt; version management should be invisible to the end user when possible.
What is the expected flow for creating a new version of prompt? Should the user call create with the same prompt name but specify version 2, or call update? If the latter, will update auto increment the version?
Description
[Propose Search Prompt API]
Related Issues
Resolves #[https://github.com//issues/3711]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.