Skip to content

Add error handling for plan&execute agent #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented May 13, 2025

Description

  1. Remove line separator from tool's response
  2. Index mapping tool support raw input for index parameter
  3. Add json extract logic for LLM output is not json format

Related Issues

#3848

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@pyek-bot
Copy link
Contributor

Thanks for the fixes @Hailong-am ! Let me know when it is ready for review. Can you also please create an issue for the fixes involved in this PR? Thanks!

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 14, 2025 05:38 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 14, 2025 05:38 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 14, 2025 05:38 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 14, 2025 05:38 — with GitHub Actions Inactive
@Hailong-am Hailong-am marked this pull request as ready for review May 14, 2025 05:53
@Hailong-am
Copy link
Contributor Author

Thanks for the fixes @Hailong-am ! Let me know when it is ready for review. Can you also please create an issue for the fixes involved in this PR? Thanks!

@pyek-bot PR description updated with issue number and the what's the actual fix, please help to take a look

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (c3b1fd6) to head (3f00b45).

Files with missing lines Patch % Lines
...thms/agent/MLPlanExecuteAndReflectAgentRunner.java 0.00% 2 Missing ⚠️
...g/opensearch/ml/engine/tools/IndexMappingTool.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3845      +/-   ##
============================================
+ Coverage     77.98%   77.99%   +0.01%     
- Complexity     7316     7320       +4     
============================================
  Files           655      655              
  Lines         33037    33043       +6     
  Branches       3708     3709       +1     
============================================
+ Hits          25764    25773       +9     
+ Misses         5688     5684       -4     
- Partials       1585     1586       +1     
Flag Coverage Δ
ml-commons 77.99% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 14, 2025 17:35 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 14, 2025 17:35 — with GitHub Actions Inactive
Copy link
Contributor

@pyek-bot pyek-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants