Skip to content

feat: remove unnecessary native lib file to reduce zip file size #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented Apr 16, 2025

Description

[Describe what this change achieves]

Related Issues

#3733

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval April 16, 2025 06:23 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval April 16, 2025 06:23 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval April 16, 2025 06:23 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval April 16, 2025 06:23 — with GitHub Actions Inactive
@Hailong-am Hailong-am changed the title reduce zip file size feat: remove unnecessary native lib file to reduce zip file size Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (c3b1fd6) to head (8696d51).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3742      +/-   ##
============================================
+ Coverage     77.98%   77.99%   +0.01%     
- Complexity     7316     7320       +4     
============================================
  Files           655      655              
  Lines         33037    33037              
  Branches       3708     3708              
============================================
+ Hits          25764    25768       +4     
+ Misses         5688     5683       -5     
- Partials       1585     1586       +1     
Flag Coverage Δ
ml-commons 77.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval April 16, 2025 07:28 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval April 16, 2025 07:28 — with GitHub Actions Inactive
@Hailong-am Hailong-am marked this pull request as ready for review April 16, 2025 07:41
@Hailong-am Hailong-am marked this pull request as draft May 6, 2025 06:20
@Hailong-am
Copy link
Contributor Author

the zip published to maven repository may different based on platform

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env-require-approval May 13, 2025 06:26 — with GitHub Actions Error
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 13, 2025 06:26 — with GitHub Actions Inactive
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env-require-approval May 13, 2025 06:26 — with GitHub Actions Failure
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 13, 2025 06:26 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 13, 2025 17:54 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval May 13, 2025 17:54 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant