Updating deprecated options

[landon-lengyel]

Description

Updates options that are marked as deprecated.

Issues Resolved

Resolves issue #9466 if these two options are all that's changed.

Version

v2.19.1

Frontend features

n/a

Checklist

• By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
  For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

[kolchfa-aws]

@landon-lengyel Could you please resolve DCO?

[kolchfa-aws]

@cwperks Could you please review this PR?

[cwperks]

@landon-lengyel These settings still exist in the security plugin and are not marked as deprecated.

I see logic in the security plugin that either configuration is permissible.

Are you experiencing any errors configuring with the documented settings?

[landon-lengyel]

@kolchfa-aws I'm sorry, I'm not sure what to do for the DCO. I did include Signed-off-by: Landon Lengyel <landon@almonde.org> in the commit, so I'm not sure why it's marked that check as failed.

[cwperks]

@reta I see you have the security plugin settings marked as deprecated in opensearch-project/security@e2a06f0.

Is there a plan to remove them? The options I see are 1) remove the deprecated setting or 2) undeprecate the setting and support with both the plugins.security. prefix and without.

[landon-lengyel]

@cwperks It looks like you were able to answer your own question, but to clarify yes I am seeing warnings in the deprecation logs. Such as:

{"type": "deprecation", "timestamp": "2025-03-19T09:30:58,299-06:00", "level": "DEPRECATION", "component": "o.o.d.c.s.Settings", "cluster.name": "osc01", "node.name": "osc01n04", "message": "[plugins.security.ssl.transport.enforce_hostname_verification] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version." }

There's a bit more info about that on security issue 4780

[kolchfa-aws]

@landon-lengyel To fix DCO, rebase the branch as described here https://github.com/opensearch-project/documentation-website/pull/9602/checks?check_run_id=40407368811.

[reta]

@reta I see you have the security plugin settings marked as deprecated in opensearch-project/security@e2a06f0.

Oh yeah, thanks @cwperks , I think those all are in core (netty4 transport module) now, we could removed then in 3.0.0, thank you

[kolchfa-aws]

@landon-lengyel Do you still plan to proceed with this PR?