Skip to content

Add min and max threads parameters to tiered cache #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Add min and max threads parameters to tiered cache #10276

merged 1 commit into from
Jul 16, 2025
+2 −0

Conversation

kolchfa-aws
Copy link
Collaborator

Closes #9708

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws
Add min and max threads parameters to tiered cache
ab558a5 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator Author

@sgup432 Please review this PR. I see in the comments the default value for max_threads is 1.5*CPU_CORES but it seems to be initialized to a default of CPU_CORES. Please verify. Thanks!

@kolchfa-aws kolchfa-aws added backport 3.1 Tech review PR: Tech review in progress labels Jul 15, 2025
@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Tech review PR: Tech review in progress labels Jul 16, 2025
natebower
natebower approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed their assignment Jul 16, 2025
@natebower natebower removed the Editorial review PR: Editorial review in progress label Jul 16, 2025
@natebower natebower merged commit 70ec42b into main Jul 16, 2025
12 checks passed
@natebower natebower deleted the issue-9708 branch July 16, 2025 18:50
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2025
@github-actions
Add min and max threads parameters to tiered cache (#10276)
b8e0560 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 70ec42b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 16, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 16, 2025
@opensearch-trigger-bot
Add min and max threads parameters to tiered cache (#10276) (#10316)
c37ef00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgup432 sgup432 sgup432 approved these changes

@natebower natebower natebower approved these changes

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

@sumobrian sumobrian Awaiting requested review from sumobrian sumobrian is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] [Tiered Caching] Add setting to define max/min write threads for ehcache disk cache.
3 participants
@kolchfa-aws @sgup432 @natebower